hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.86k stars 9.2k forks source link

aws_eks_node_group - Missing Support for spot_allocation_strategy, protect_from_scale_in, on_demand_base_capacity etc #21707

Open jseiser opened 3 years ago

jseiser commented 3 years ago

Community Note

Description

I believe aws_eks_node_group is missing alot of option related to Mixed Instances.

spot_allocation_strategy
protect_from_scale_in
on_demand_base_capacity
on_demand_percentage_above_base_capacity

New or Affected Resource(s)

Resource: aws_eks_node_group

References

EKS

jb-2020 commented 2 years ago

Additionally, aws_eks_node_group is missing support for setting suspended_processes as a parameter to the ASG it creates.

gillesdouaire commented 2 years ago

Support for price and capacity optimized for allocation strategy is a must for us:

re: https://aws.amazon.com/about-aws/whats-new/2022/11/amazon-ec2-price-capacity-optimized-allocation-strategy-provisioning-ec2-spot-instances/

z0rc commented 2 years ago

Not going to happen on provider side until AWS EKS API actually supports this. You can check for available options at https://docs.aws.amazon.com/eks/latest/APIReference/API_CreateNodegroup.html

Everyone commenting in this issue need to bring this to their AWS TAMs.

gillesdouaire commented 2 years ago

@z0rc so I guess the only way for now is to do it via the aws_autoscaling_group...

bryantbiggs commented 2 months ago

these are all dependent on the upstream service - once EKS managed node groups support these configurations, the provider can therefore support them (most likely via custom launch templates unless the EKS API dictates differently)