hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.84k stars 9.19k forks source link

Add support for App Runner VPC Connectors #23090

Closed jvisker closed 2 years ago

jvisker commented 2 years ago

Community Note

Description

Add support for VPC connectors in App Runner.

New or Affected Resource(s)

Potential Terraform Configuration

//New resource
resource "aws_apprunner_vpc_connector" "connector" {
  vpc_connector_name = "name"
  subnets            = ["subnet1", "subnet2"]
  security_groups    = ["sg1", "sg2"] // optional

  // Needs to at least output the arn
}

resource "aws_apprunner_service" "service" {
  // Add new section here to existing resource
  network_configuration {
    egress_configuration {
      egress_type       = "VPC"                                     // OR "DEFAULT"
      vpc_connector_arn = aws_apprunner_vpc_connector.connector.arn //Only valid if egress_type is VPC
    }
  }
}

References

Yoshiitaka commented 2 years ago

I am just currently working on this issue with @Synohara-san.

andymac4182 commented 2 years ago

Thanks @Yoshiitaka @Synohara-san. Excited to get this :)

Yoshiitaka commented 2 years ago

We've created a Pull Request to fix this Issue. https://github.com/hashicorp/terraform-provider-aws/pull/23173

github-actions[bot] commented 2 years ago

This functionality has been released in v4.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 2 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.