search

hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.78k stars 9.14k forks source link

resource/aws_ssoadmin_permission_set: Add validator for ISO 8601 format for `session_duration` #24246

Open gdavison opened 2 years ago

gdavison commented 2 years ago

Description

The session_duration duration on the resource aws_ssoadmin_permission_set needs to be a valid ISO 8601 duration value. The current validation checks that the length is between 1 and 100 characters.

Affected Resource

References

ISO 8601 duration: https://en.wikipedia.org/wiki/ISO_8601#Durations

iamgeef commented 2 years ago

Seems to be set on the AWS API side, TF would just be abiding by AWS's API config so doubt this one would be changed in TF. https://docs.aws.amazon.com/singlesignon/latest/APIReference/API_CreatePermissionSet.html#singlesignon-CreatePermissionSet-request-SessionDuration

github-actions[bot] commented 6 months ago

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!