hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.82k stars 9.17k forks source link

aws_grafana_workspace support all workspace data sources #24753

Closed fraserc182 closed 2 years ago

fraserc182 commented 2 years ago

Community Note

Description

Currently the aws_grafana_workspace resource only supports the following data sources:

AMAZON_OPENSEARCH_SERVICE, 
CLOUDWATCH
PROMETHEUS
XRAY
TIMESTREAM
SITEWISE

However, the API for this also supports ATHENA & REDSHIFT Can these please be included?

New or Affected Resource(s)

Potential Terraform Configuration

resource "aws_grafana_workspace" "ops" {
  account_access_type      = "CURRENT_ACCOUNT"
  authentication_providers = ["AWS_SSO"]
  permission_type          = "SERVICE_MANAGED"
  role_arn                 = aws_iam_role.assume.arn
  data_sources             = [ "CLOUDWATCH", "TIMESTREAM", "REDSHIFT", "ATHENA" ]
}

References

fraserc182 commented 2 years ago

Looking at this, it seems this might just be a documentation update. Using the following code works and creates the data source as expected.

resource "aws_grafana_workspace" "ops" {
  account_access_type      = "CURRENT_ACCOUNT"
  authentication_providers = ["AWS_SSO"]
  permission_type          = "SERVICE_MANAGED"
  role_arn                 = aws_iam_role.assume.arn
  data_sources             = [ "CLOUDWATCH", "TIMESTREAM", "REDSHIFT", "ATHENA" ]
}
github-actions[bot] commented 2 years ago

This functionality has been released in v4.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 2 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.