hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.74k stars 9.1k forks source link

aws_lakeformation_lf_tag throws schema validation error Too many list items, even though soft limit is increased in AWS account. #26633

Closed bharatbolisetty closed 1 year ago

bharatbolisetty commented 2 years ago

Community Note

Terraform CLI and Terraform AWS Provider Version

Terraform

AWS Provider

Affected Resource(s)

Terraform Configuration Files

provider "aws" {
  region  = "us-west-2"
  version = "~> 4.22.0"
}

resource "aws_lakeformation_lf_tag" "lftags" {
  key      = "module"
  values   = ["module1",  "module2",  "module3",  "module4",  "module5",  "module6",  "module7",  "module8",  "module9",  "module10",  "module11",  "module12",  "module13",  "module14",  "module15",  "module16",  "module17"]
}

Debug Output

https://gist.github.com/bharatbolisetty/8fa114f712d48705a4b66718e8c621ad

Panic Output

Expected Behavior

For aws_lakeformation_lf_tag number of values for a tag is 15 which is soft limit, this can be increased using service quota request. Should not have max count validation on values attribute of aws_lakeformation_lf_tag resource.

Actual Behavior

When values attribute have more than 15 elements it throws Too many list items error in terraform validate. Complete error below

Error: Too many list items
│ 
│   with aws_lakeformation_lf_tag.lftags,
│   on main.tf line 24, in resource "aws_lakeformation_lf_tag" "lftags":
│   24:   values   = ["module1",  "module2",  "module3",  "module4",  "module5",  "module6",  "module7",  "module8",  "module9",  "module10",  "module11",  "module12",  "module13",  "module14",  "module15",  "module16",  "module17"]
│ 
│ Attribute supports 15 item maximum, but config has 17 declared.
╵

Steps to Reproduce

  1. terraform init
  2. terraform validate

Important Factoids

We placed service quota increase request on lake formation Number of values per tag and the soft limit on number of values per tag 15 is increased to 100.

References

https://docs.aws.amazon.com/general/latest/gr/lake-formation.html

bharatbolisetty commented 2 years ago

Hi @justinretzolk,

I think this PR https://github.com/hashicorp/terraform-provider-aws/pull/26546 fixes this issue, can you please check and do the needful.

gh-bbolisetty commented 1 year ago

Hi @justinretzolk,

Can you prioritise reviewing this PR https://github.com/hashicorp/terraform-provider-aws/pull/26546.

justinretzolk commented 1 year ago

Hey @bharatbolisetty and @bbolisetty-gh 👋 Thank you for checking in on this. Unfortunately, I'm not able to provide an estimate on when #26546 will be reviewed/merged due to the potential of shifting priorities (we prioritize work by count of ":+1:" reactions, as well as a few other things). For more information on how we prioritize, check out out prioritization guide.

github-actions[bot] commented 1 year ago

This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.