hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.71k stars 9.07k forks source link

AWS KMS External Key Store #28092

Open ewbankkit opened 1 year ago

ewbankkit commented 1 year ago

Today, AWS Key Management Service (AWS KMS) introduces the External Key Store (XKS), a new feature for customers who want to protect their data with encryption keys stored in an external key management system under their control.

Announcement. Blog post.

Requires AWS SDK for Go v1.44.148: https://github.com/hashicorp/terraform-provider-aws/pull/28085.

Affected Resource(s)

github-actions[bot] commented 1 year ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

bschaatsbergen commented 1 year ago

I'll happily pick this up in a few days.

bschaatsbergen commented 1 year ago

Starting on this now 👍

albgus commented 1 year ago

I believe this affects the aws_kms_key resource as well. The docs for CreateKey states:

To create a KMS key in an external key store, use the Origin parameter with a value of EXTERNAL_KEY_STORE and an XksKeyId parameter that identifies an existing external key.

So to actually be able to create keys using the external store these parameters would need to be added on the aws_kms_key resource.

bschaatsbergen commented 1 year ago

Thanks for flagging this @albgus. I'll update the PR accordingly.

mmianl commented 4 months ago

Any chance this gets picked up again?