hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.85k stars 9.19k forks source link

[Enhancement]: Add Description and Parameter arguments to Sagemaker Feature Definition #28146

Open nealrp opened 1 year ago

nealrp commented 1 year ago

Description

When creating features in a feature group (https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/sagemaker_feature_group#feature-definition) we should have the ability to add a required feature_name and feature_type as well as an optional description and a parameter map.

Affected Resource(s) and/or Data Source(s)

aws_sagemaker_feature_group

Potential Terraform Configuration

Is this the source code? https://github.com/SebastianUA/terraform-aws-sagemaker/blob/master/sagemaker_feature_group.tf

dynamic "feature_definition" {
    iterator = feature_definition
    for_each = var.sagemaker_feature_group_feature_definition

    content {
      feature_name = lookup(feature_definition.value, "feature_name", null)
      feature_type = lookup(feature_definition.value, "feature_type", null)
      description = lookup(feature_definition.value, "description", null)
      parameter = lookup(feature_definition.value, "parameter", null)
    }
  }

References

https://github.com/SebastianUA/terraform-aws-sagemaker/blob/master/sagemaker_feature_group.tf

Would you like to implement a fix?

No

github-actions[bot] commented 1 year ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

DrFaust92 commented 1 year ago

this is not currently supported in the AWS api

nealrp commented 1 year ago

@DrFaust92 Available now through https://sagemaker.readthedocs.io/en/stable/api/prep_data/feature_store.html

update_feature_metadata(feature_name, description=None, parameter_additions=None, parameter_removals=None)
Update a feature metadata and add/remove metadata.

Parameters
feature_name ([str](https://docs.python.org/3/library/stdtypes.html#str)) ā€“ name of the feature to update.

description ([str](https://docs.python.org/3/library/stdtypes.html#str)) ā€“ description of the feature to update.

parameter_additions (Sequence[Dict[[str](https://docs.python.org/3/library/stdtypes.html#str), [str](https://docs.python.org/3/library/stdtypes.html#str)]) ā€“ list of feature parameter to be added.

parameter_removals (Sequence[[str](https://docs.python.org/3/library/stdtypes.html#str)]) ā€“ list of feature parameter key to be removed.

Returns
Response dict from service.

Return type
Dict[[str](https://docs.python.org/3/library/stdtypes.html#str), Any]