hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.84k stars 9.19k forks source link

[Enhancement]: Support for Managing Event Topics in Directory Service Directory #28279

Open breathingdust opened 1 year ago

breathingdust commented 1 year ago

Description

Adds support for enabling disabling publishing to an SNS topic for a configured directory.

Affected Resource(s) and/or Data Source(s)

aws_directory_service_directory

Potential Terraform Configuration

resource "aws_directory_service_directory" "directory" {
  event_registration {
    topic_name = "SNSTopic"
  }
}

References

Would you like to implement a fix?

None

github-actions[bot] commented 1 year ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

DrFaust92 commented 1 year ago

consider separate resource for composability.

matthewbarreiro commented 6 months ago

This is particularly important for AD connectors, as they don't support logs.

Also:

consider separate resource for composability.

I would agree. Especially since when creating a new SNS topic through the AWS console, it is created with the name DirectoryMonitoring_<directory id> e.g. DirectoryMonitoring_d-1111111111. A separate resource would allow for matching this pattern.