hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.82k stars 9.16k forks source link

[Enhancement]: Add support for credentials SecretArn attribute in quicksight_data_source #28484

Closed grzegorzb1990 closed 1 month ago

grzegorzb1990 commented 1 year ago

Description

According to the AWS API documentation, it is possible to create a new data source, using credentials stored in Secret Manager . This way I would not have to store credentials in plain text in the terraform state. image

Affected Resource(s) and/or Data Source(s)

quicksight_data_source

Potential Terraform Configuration

resource "aws_quicksight_data_source" "snowflake" {
  data_source_id = "snowflake"
  name           = "SNOWFLAKE"

  type = "SNOWFLAKE"

  parameters {
    snowflake {
      database  = "SNOWFLAKE"
      host      = "snowflakecomputing.com"
      warehouse = "SNOWFLAKE_WH"
    }
  }

  credentials {
    secret_arn = "arn:aws:secretsmanager:us-west-2:123456789012:secret:my-path/my-secret-name-1a2b3c"
  }
}

References

https://docs.aws.amazon.com/quicksight/latest/APIReference/API_CreateDataSource.html https://docs.aws.amazon.com/quicksight/latest/APIReference/API_DataSourceCredentials.html#QS-Type-DataSourceCredentials-SecretArn

Would you like to implement a fix?

No

github-actions[bot] commented 1 year ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

alfredgamulo commented 1 year ago

There's a PR for this. Can it be reviewed, please?

shahriteshj commented 7 months ago

@justinretzolk : Who can help review this PR or is there anything pending because of which PR is not being reviewed?

github-actions[bot] commented 1 month ago

[!WARNING] This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

github-actions[bot] commented 1 month ago

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 2 days ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.