hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.81k stars 9.16k forks source link

[Bug]: Sensitivity level parameter is not available in sqli_match_statement (aws_wafv2_web_acl resource #29672

Closed tamilver-amzn closed 4 months ago

tamilver-amzn commented 1 year ago

Terraform Core Version

latest

AWS Provider Version

latest

Affected Resource(s)

aws_waf_web_acl sqli_match_statement

Expected Behavior

Since sensitivity parameter is not available, waf sqli_match_statement is creating without SensitivityLevel. This value either it is LOW or HIGH.

Refer: https://aws.amazon.com/about-aws/whats-new/2022/07/aws-waf-sensitivity-levels-sql-injection-rule-statements/

This is available in cloudformation not in terraform.

Actual Behavior

Since SensitivityLevel parameter is not available, WAF rule is getting creating without that value.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

NA

Steps to Reproduce

terraform init terraform apply

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

github-actions[bot] commented 1 year ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

tyler-robbins2 commented 9 months ago

Hi there,

We are trying to follow the recommendations from this article: https://docs.aws.amazon.com/en_us/waf/latest/developerguide/waf-rule-statement-type-sqli-match.html

The HIGH setting detects more SQL injection attacks, and is the recommended setting.

Is there any movement on this enhancement/bug?

We have to manually modify the value to HIGH in the AWS WAF UI, which breaks terraform state and gets overwritten whenever we update.

github-actions[bot] commented 4 months ago

[!WARNING] This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

github-actions[bot] commented 4 months ago

This functionality has been released in v5.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 2 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.