hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.76k stars 9.11k forks source link

[Docs]: Missing endpoint_auto_confirms limitation for email endpoints #29860

Open trz-scoulibaly opened 1 year ago

trz-scoulibaly commented 1 year ago

Documentation Link

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/sns_topic_subscription#endpoint_auto_confirms

Description

The documentation doesn't state explicitly that the endpoint_auto_confirms doesn't work for email endpoints.

References

https://github.com/hashicorp/terraform-provider-aws/blob/v4.57.1/internal/service/sns/topic_subscription.go (Line 185) :

    if strings.Contains(protocol, "email") {
        waitForConfirmation = false
    }

Would you like to implement a fix?

Yes

github-actions[bot] commented 1 year ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

justinretzolk commented 1 year ago

Hey @trz-scoulibaly 👋 Thank you for taking the time to raise this! We'll keep an eye out for a follow up PR that updates the documentation. If you decide you'd prefer not to work on the fix, please do let us know so one of the maintainers can pick this up.