hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.83k stars 9.18k forks source link

[Enhancement]: aws_vpn_connection - enable_acceleration - remove transit_gateway_id check #31673

Closed dvmrry closed 1 year ago

dvmrry commented 1 year ago

Description

Creating site-to-site VPN connections via Terraform currently requires a transit_gateway_id.

This is no longer strictly necessary or desired when attempting to create VPN connections that will be associated to a NetworkManager core_network as the VPN resource may never directly associate to a Transit Gateway in this scenario.

Affected Resource(s) and/or Data Source(s)

No response

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

No

github-actions[bot] commented 1 year ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

dvmrry commented 1 year ago

Upon further review, it appears that you can pass an empty string to the transit_gateway_id argument without the sanity check failing.

I will close this for now, though this behavior may need to be documented.

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.