hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.77k stars 9.13k forks source link

[Enhancement]: Update aws_appconfig_deployment to support KmsKeyIdentifier argument #31999

Closed smastrorocco closed 10 months ago

smastrorocco commented 1 year ago

Description

AWS AppConfig now supports configuration profiles to use Secrets Manager. However, when using this option, if the source secret is encrypted using a CMK, you must provide the KMS Key ID via KmsKeyIdentifier when calling the StartDeployment API.

Affected Resource(s) and/or Data Source(s)

Potential Terraform Configuration

resource "aws_appconfig_deployment" "example" {
  application_id           = aws_appconfig_application.example.id
  configuration_profile_id = aws_appconfig_configuration_profile.example.configuration_profile_id
  configuration_version    = aws_appconfig_hosted_configuration_version.example.version_number
  deployment_strategy_id   = aws_appconfig_deployment_strategy.example.id
  description              = "My example deployment"
  environment_id           = aws_appconfig_environment.example.environment_id
  kms_key_identifier       = aws_kms_key.example.id

  tags = {
    Type = "AppConfig Deployment"
  }
}

References

https://docs.aws.amazon.com/appconfig/2019-10-09/APIReference/API_StartDeployment.html https://awscli.amazonaws.com/v2/documentation/api/latest/reference/appconfig/start-deployment.html

Would you like to implement a fix?

None

github-actions[bot] commented 1 year ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

github-actions[bot] commented 10 months ago

This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 9 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.