hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.7k stars 9.07k forks source link

networkmanager: Create typed attachment accepters #34523

Open gdavison opened 9 months ago

gdavison commented 9 months ago

Description

Currently, there are four attachment types with corresponding resource types, aws_networkmanager_connect_attachment, aws_networkmanager_site_to_site_vpn_attachment, aws_networkmanager_transit_gateway_route_table_attachment, and aws_networkmanager_vpc_attachment. However, because of the API implementation, there is a single attachment accepter which requires the type of the attachment as a synthetic parameter.

Because there are separate attachment types, the implementation of the CRUD operations in aws_networkmanager_attachment_accepter requires a switch statement for each attachment type.

For clarity for users, as well as simplifying implementation, split the resource type aws_networkmanager_attachment_accepter into four corresponding resource types. Deprecate aws_networkmanager_attachment_accepter.

Affected Resource(s) and/or Data Source(s)

New resource types

Deprecation

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

None

github-actions[bot] commented 9 months ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue