Currently, there are four attachment types with corresponding resource types, aws_networkmanager_connect_attachment, aws_networkmanager_site_to_site_vpn_attachment, aws_networkmanager_transit_gateway_route_table_attachment, and aws_networkmanager_vpc_attachment. However, because of the API implementation, there is a single attachment accepter which requires the type of the attachment as a synthetic parameter.
Because there are separate attachment types, the implementation of the CRUD operations in aws_networkmanager_attachment_accepter requires a switch statement for each attachment type.
For clarity for users, as well as simplifying implementation, split the resource type aws_networkmanager_attachment_accepter into four corresponding resource types. Deprecate aws_networkmanager_attachment_accepter.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
Volunteering to Work on This Issue
If you are interested in working on this issue, please leave a comment.
If this would be your first contribution, please review the contribution guide.
Description
Currently, there are four attachment types with corresponding resource types,
aws_networkmanager_connect_attachment
,aws_networkmanager_site_to_site_vpn_attachment
,aws_networkmanager_transit_gateway_route_table_attachment
, andaws_networkmanager_vpc_attachment
. However, because of the API implementation, there is a single attachment accepter which requires the type of the attachment as a synthetic parameter.Because there are separate attachment types, the implementation of the CRUD operations in
aws_networkmanager_attachment_accepter
requires aswitch
statement for each attachment type.For clarity for users, as well as simplifying implementation, split the resource type
aws_networkmanager_attachment_accepter
into four corresponding resource types. Deprecateaws_networkmanager_attachment_accepter
.Affected Resource(s) and/or Data Source(s)
New resource types
aws_networkmanager_connect_attachment
aws_networkmanager_site_to_site_vpn_attachment
aws_networkmanager_transit_gateway_route_table_attachment
aws_networkmanager_vpc_attachment
Deprecation
aws_networkmanager_attachment_accepter
Potential Terraform Configuration
No response
References
No response
Would you like to implement a fix?
None