hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.87k stars 9.21k forks source link

[Enhancement]: Add ability to use multiple target groups in CodeDeploy, in place deployments #34779

Closed wagnerone closed 1 month ago

wagnerone commented 12 months ago

Description

A few months ago AWS announced the ability to manage targets in multiple ALB target groups when doing a CodeDeploy in-place deployment. Currently the provider only manages a single ALB target group for aws_codedeploy_deployment_group. Please enhance it to manage multiple ALB target groups.

Affected Resource(s) and/or Data Source(s)

Potential Terraform Configuration

resource "aws_codedeploy_deployment_group" "default" {
  app_name              = aws_codedeploy_app.app.name
  deployment_group_name = "app deployment group"
  service_role_arn      = aws_iam_role.role_code_deploy.arn

  autoscaling_groups = var.autoscaling_group_names

  deployment_style {
    deployment_option = local.deployment_style
    deployment_type   = "IN_PLACE"
  }

  load_balancer_info {
    target_group_info {[var.target_group_name_alb_01, var.target_group_name_alb_02]}
  }

  auto_rollback_configuration {
    enabled = true
    events  = ["DEPLOYMENT_FAILURE"]
  }
}

References

Would you like to implement a fix?

None

github-actions[bot] commented 12 months ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

wagnerone commented 10 months ago

What is the next step to get some traction on this request? Thanks!

justinretzolk commented 10 months ago

Hey @wagnerone 👋 Thanks for checking in here! We base our prioritization on the count of :+1: reactions and a few other considerations (more information: prioritization guide).

wagnerone commented 10 months ago

@justinretzolk Thank you for that extra info. I'll sit tight for now.

vinz94f commented 8 months ago

Hello,

In the AWS web console, it's possible to select several target groups.

Capture d’écran 2024-03-14 à 16 40 05

But it's not possible to do this with the "aws_codedeploy_deployment_group" terraform resource.

Regards,

ewbankkit commented 1 month ago

I have verified that you can configured multiple target groups on the aws_codedeploy_deployment_group resource:

  load_balancer_info {
    target_group_info {
      name = "acc-test-codedeploy-dep-group-1"
    }

    target_group_info {
      name = "acc-test-codedeploy-dep-group-2"
    }

    target_group_info {
      name = "acc-test-codedeploy-dep-group-3"
    }
  }
github-actions[bot] commented 1 month ago

[!WARNING] This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

github-actions[bot] commented 1 month ago

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 6 days ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.