hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.63k stars 9.01k forks source link

Feature Request: Add support for Cloudformation Stack Termination Protection #3496

Open petewilcock opened 6 years ago

petewilcock commented 6 years ago

Affected Resource(s)

Background

AWS released Termination protection for Cloudformation Stacks in August 2017:

https://aws.amazon.com/about-aws/whats-new/2017/09/aws-cloudformation-provides-stack-termination-protection/ https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/using-cfn-protect-stacks.html

Feature Request

Addition of a termination_protection attribute in the aws_cloudformation_stack resource definition.

mwarkentin commented 6 years ago

+1!

Although I wonder if termination protection should be a separate resource from the stack itself? This is how it's modelled in the AWS API, and it would allow us to enable it for stacks which aren't managed themselves within Terraform using a data provider + termination protection resource.

mwarkentin commented 5 years ago

See https://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_UpdateTerminationProtection.html

lorengordon commented 5 years ago

Can also enable termination protection directly when creating the stack...

ksrisurapaneni commented 4 years ago

Any idea if this enhancement is coming? It will be really helpful having termination_protection attribute in Terraform aws_cloudformation_stack.

marinpurgar commented 2 years ago

:+1:

macgruber99 commented 1 year ago

I see the issue is closed but there still isn't an parameter for updating termination protection on stacks in the cloudformation resource. Is this forthcoming?

Rishang commented 8 months ago

Agree

brianluisgomez commented 2 months ago

Any news on this one?