hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.83k stars 9.17k forks source link

[Enhancement]: Provide a way to retrieve the id of the default Sagemaker Service Catalog portfolio #36001

Open dorranh opened 8 months ago

dorranh commented 8 months ago

Description

As a user of Sagemaker, I would like to be able to provision new Sagemaker Domains via Terraform which use a custom default execution role that has access to the default service catalog portfolio which AWS provides.

While I can enable this portfolio with the aws_sagemaker_servicecatalog_portfolio_status resource, it does not return the portfolio ID required to grant my custom IAM role access to the portfolio via the aws_servicecatalog_principal_portfolio_association resource (see https://github.com/hashicorp/terraform-provider-aws/issues/28348).

This requires us to introduce manual steps in our deployment process or use workarounds like the one described in https://github.com/hashicorp/terraform-provider-aws/issues/28348.

Allowing the aws_servicecatalog_portfolio resource to query by name rather than an id as previously suggested in https://github.com/hashicorp/terraform-provider-aws/issues/20719 would be one fix for this, though there may also be other solutions to the above problem.

Affected Resource(s) and/or Data Source(s)

Potential Terraform Configuration

No response

References

Would you like to implement a fix?

None

github-actions[bot] commented 8 months ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue