hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.83k stars 9.18k forks source link

[Enhancement]: Add support for secretamanger integration in location_uri for AWS Appconfig Configuartion profile #36401

Closed ajays-y closed 7 months ago

ajays-y commented 7 months ago

Description

Add support for secretamanger integration in location_uri for AWS Appconfig Configuartion profile

location_uri

New configuration source is added for freeform configuration profile, requesting to provide option to use same with terraform under location_uri parameter.

Affected Resource(s) and/or Data Source(s)

Resource: aws_appconfig_configuration_profile

Potential Terraform Configuration

location_uri - (Required, Forces new resource) URI to locate the configuration. You can specify the AWS AppConfig hosted configuration store, Systems Manager (SSM) document, an SSM Parameter Store parameter, or an Amazon S3 object. For the hosted configuration store, specify hosted. For an SSM document, specify either the document name in the format ssm-document://<Document_name> or the ARN. For a parameter, specify either the parameter name in the format ssm-parameter://<Parameter_name> or the ARN. For an Amazon S3 object, specify the URI in the following format: s3://<bucket>/<objectKey>.

We can try giving like below for secret_manager: 

secret-manager://<secret_name>

References

No response

Would you like to implement a fix?

None

github-actions[bot] commented 7 months ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

ajays-y commented 7 months ago

Just now tested using secret manager role arn as value to location_uri, it seems to be working, would be good if added to official docs.

resource "aws_appconfig_configuration_profile" "example" { name = "example" application_id = description = location_uri = "arn:aws:secretsmanager:::secret:" retrieval_role_arn = }

github-actions[bot] commented 6 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.