[Bug]: Adding a new feature to an existing feature group causes the feature group to be replaced

[twood10-chwy]

Terraform Core Version

0.13.3

AWS Provider Version

4.67.0

Affected Resource(s)

• aws_sagemaker_feature_group

Expected Behavior

When adding a new feature to the feature group, the existing feature group should be updated and all data retained.

Actual Behavior

Adding a new feature caused the feature group to be replaced, destroying all data along with it.

Relevant Error/Panic Output Snippet

module.aws_sagemaker_feature_group.demo_feature_group must be replaced ...
       + feature_definition { # forces replacement
            + feature_name = "MY_NEW_FEATURE"
            + feature_type = "String"
         }

Terraform Configuration Files

Initial definition

resource "aws_sagemaker_feature_group" "demo_feature_group" {
  feature_group_name             = "my-demo-feature-group-name"
  record_identifier_feature_name = "USER_ID"
  event_time_feature_name        = "AT"
  role_arn                       = aws_iam_role.feature_group_role.arn
  feature_definition {
    feature_name = "USER_ID"
    feature_type = "String"
  }
  feature_definition {
    feature_name = "AT"
    feature_type = "String"
  }
  feature_definition {
    feature_name = "FEATURE_A"
    feature_type = "String"
  }
  online_store_config {
    enable_online_store = true
  }
  offline_store_config {
    s3_storage_config {
      kms_key_id = var.kms_key_arn
      s3_uri     = "s3://${var.s3_bucket}/"
    }
    table_format = "Iceberg"
  }
}

Definition with new feature

resource "aws_sagemaker_feature_group" "demo_feature_group" {
  feature_group_name             = "my-demo-feature-group-name"
  record_identifier_feature_name = "USER_ID"
  event_time_feature_name        = "AT"
  role_arn                       = aws_iam_role.feature_group_role.arn
  feature_definition {
    feature_name = "USER_ID"
    feature_type = "String"
  }
  feature_definition {
    feature_name = "AT"
    feature_type = "String"
  }
  feature_definition {
    feature_name = "FEATURE_A"
    feature_type = "String"
  }
  feature_definition {
    feature_name = "FEATURE_B"
    feature_type = "String"
  }
  online_store_config {
    enable_online_store = true
  }
  offline_store_config {
    s3_storage_config {
      kms_key_id = var.kms_key_arn
      s3_uri     = "s3://${var.s3_bucket}/"
    }
    table_format = "Iceberg"
  }
}

Steps to Reproduce

1. Create a feature group and deploy it
2. Ingest data to the feature group and verify it exists
3. Add a new feature to the feature group and deploy it
4. Verify the previously added data no longer exists

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

[github-actions[bot]]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[lsamaha1-chwy]

any updates on timelines for a release which includes @nikhil-goenka's fix branch?