[Docs]: S3 Object Lock no longer needs a token field

[tanelso2]

Documentation Link

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_object_lock_configuration#token

Description

Hi there,

The aws_s3_bucket_object_lock_configuration object type has a field called token that it claims is needed to enable Object Lock on an existing S3 bucket.

This is no longer the case. As of November 2023, AWS allows you to enable Object Lock without specifying a token, and the current versions of the Object Lock documentation makes no reference to the token field.

I just tested this out myself with a quick demo. I was able to add Object Lock to an existing bucket without a token.

We should update the documentation to make it clear that the token is deprecated and no longer needed. The current documentation implies the opposite.

References

https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lock-configure.html https://aws.amazon.com/about-aws/whats-new/2023/11/amazon-s3-enabling-object-lock-buckets/

Relates https://github.com/hashicorp/terraform-provider-aws/pull/36530.

Would you like to implement a fix?

Yes

[github-actions[bot]]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[Jyots6914]

I will work on it and I will raise PR

[github-actions[bot]]

[!WARNING] This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions[bot]]

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[tanelso2]

Fantastic, thanks everyone who worked on this!

[github-actions[bot]]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.