hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.76k stars 9.12k forks source link

[Bug]: aws_api_gateway_rest_api doesn't handle LimitExceededException #37605

Open PAKalucki opened 4 months ago

PAKalucki commented 4 months ago

Terraform Core Version

1.8.3

AWS Provider Version

5.50.0

Affected Resource(s)

aws_api_gateway_rest_api

Expected Behavior

Terraform to fail on getting exception from AWS and report the message.

Actual Behavior

Terraform runs in retry loop until timeout without reporting the exception.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_api_gateway_rest_api" "this" { name = "test-api" endpoint_configuration { types = ["REGIONAL"] } }

Steps to Reproduce

Create aws_api_gateway_rest_api with resources above the AWS quota limit.

Debug Output

2024-05-20T14:04:45.815+0200 [DEBUG] provider.terraform-provider-aws_v5.50.0_x5: HTTP Response Received: http.response.header.x_amzn_errortype=LimitExceededException rpc.method=PutRestApi rpc.service="API Gateway" tf_rpc=ApplyResourceChange http.response.header.content_type=application/json http.response.header.x_amz_apigw_id=YEZeJJdpoAMEbnA= http.response.header.x_amzn_requestid=b3d1a789-0038-4a91-bb54-9da7be2ef2f6 http.status_code=429 tf_req_id=45dd0dd4-b932-523e-ffc9-afb7caf84bf8 aws.region=us-east-1
  http.response.body=
  | {"message":"Maximum number of Resources for this API has been reached.  Please contact AWS if you need additional Resources.","retryAfterSeconds":null}
   http.duration=6063 http.response.header.date="Mon, 20 May 2024 12:04:47 GMT" rpc.system=aws-api tf_aws.sdk=aws-sdk-go-v2 tf_aws.signing_region="" tf_provider_addr=registry.terraform.io/hashicorp/aws tf_resource_type=aws_api_gateway_rest_api http.response_content_length=152 tf_mux_provider="*schema.GRPCProviderServer" @caller=github.com/hashicorp/aws-sdk-go-base/v2@v2.0.0-beta.53/logging/tf_logger.go:45 @module=aws timestamp="2024-05-20T14:04:45.815+0200"
aws_api_gateway_rest_api.this: Still modifying... [id=dfnzajd9nj, 3m50s elapsed]

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

github-actions[bot] commented 4 months ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue