hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.76k stars 9.12k forks source link

[New Resource]: Add support for Grafana Service Account and Token #37645

Closed gingersnapz closed 2 months ago

gingersnapz commented 4 months ago

Description

With the 10.4 version release for AWS Managed Grafana, new APIs were introduced to manage service accounts and service account tokens.

Requested Resource(s) and/or Data Source(s)

aws_grafana_workspace_service_account aws_grafana_workspace_service_account_token

Potential Terraform Configuration

resource "aws_grafana_workspace_service_account" "example" {
  grafana_role_name  = "ADMIN"
  name               = "myAdmin"
  workspace_id       = "grafana_workspace_id"
}

resource "aws_grafana_workspace_service_account_token" "tkn" {
  name               = "admin_token_a"
  service_account_id = aws_grafana_workspace_service_account.example.id
  seconds_to_live    = 3600
  workspace_id       = "grafana_workspace_id"
}

References

https://docs.aws.amazon.com/grafana/latest/APIReference/API_Operations.html https://aws.amazon.com/about-aws/whats-new/2024/05/amazon-managed-grafana-supports-version-10-4/ https://docs.aws.amazon.com/sdk-for-go/api/service/managedgrafana/

Would you like to implement a fix?

No

github-actions[bot] commented 4 months ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

bonclay7 commented 4 months ago

Interested to take this one

aristosvo commented 4 months ago

@bonclay7 did you already look at Go SDK v2 for the Grafana Service? FYI, I've picked that one up in https://github.com/hashicorp/terraform-provider-aws/pull/37831.

bonclay7 commented 3 months ago

@aristosvo Thanks for this. I was going to implement only the new resources in v2

github-actions[bot] commented 2 months ago

[!WARNING] This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

github-actions[bot] commented 2 months ago

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 1 month ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.