hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.87k stars 9.21k forks source link

[Enhancement]: SageMaker EndpointConfig VpcConfig and ExecutionRoleArn supports #37659

Open major-hmhco opened 6 months ago

major-hmhco commented 6 months ago

Description

The existing aws_sagemaker_endpoint_configuration resource currently does not support the VpcConfig or ExecutionRoleArn parameters in the CreateEndpointConfig API.

This means that we cannot adequately constrain created EndpointConfigs/Endpoints to run within specified VPCs (and with specified SecurityGroupIds), instead these (AFAIK) deploy to the account's default VPC. We also cannot specify an execution role ARN for these endpoints.

In order to ensure appropriate parity with AWS APIs, we would request that the resource be updated with support for these API parameters.

Affected Resource(s) and/or Data Source(s)

Potential Terraform Configuration

resource "aws_sagemaker_endpoint_configuration" "this" {
  /* 
  preserve existing behaviour
    name = ""
    tags = {}
    [...]
 */
  execution_role_arn = "arn:aws:iam:..."
  vpc_config {
    subnets = ["abc", "def"]
    security_group_ids = ["ghi", "jkl"]
  }
}

References

https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_CreateEndpointConfig.html#sagemaker-CreateEndpointConfig-request-VpcConfig

https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_CreateEndpointConfig.html#sagemaker-CreateEndpointConfig-request-ExecutionRoleArn

Would you like to implement a fix?

None

github-actions[bot] commented 6 months ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue