hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.72k stars 9.08k forks source link

[Enhancement]: Disable rotation on RDS managed master password #37779

Open tomthetommy opened 3 months ago

tomthetommy commented 3 months ago

Description

I'm using various terraform modules to configure RDS instances and would like to store the master passwords in secretsmanager. My issue is that I can't disable password rotation via terraform, there is no option. https://registry.terraform.io/providers/hashicorp/aws/5.51.0/docs/resources/db_instance

I'd like to be given the option to set a flag to disable password rotation in secrets manager.

Similar issue mentioned here https://github.com/terraform-aws-modules/terraform-aws-rds/issues/538

Affected Resource(s) and/or Data Source(s)

aws_db_resource

terraform-aws-modules/rds/aws

Potential Terraform Configuration

No response

References

No response

Would you like to implement a fix?

No

github-actions[bot] commented 3 months ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

sadmdbrezack-metabolon commented 2 weeks ago

I think we just need a new field on aws_db_instance to disable the creation of the secret rotation or leave it disabled by default.

It's not a lot of work for devs to add a aws_secretsmanager_secret_rotation in post