hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.73k stars 9.09k forks source link

Correctly ignore `use_fips_endpoint` when using custom service endpoint regardless of source of either setting #37876

Open gdavison opened 3 months ago

gdavison commented 3 months ago

Description

The PR #34233 ignores the setting of use_fips_endpoint when a custom endpoint is configured on the provider. However, it does not handle the case when an endpoint is configured in the shared configuration file or using an environment variable.

PR #34233 also added a test to confirm that the default FIPS endpoint is returned when use_fips_endpoint is set and that the custom endpoint is returned without error when both a custom endpoint and use_fips_endpoint are set.

Additional validation is needed for the following combinations:

Note that this should not include validating that the FIPS endpoint returned is a routable address. See https://github.com/aws/aws-sdk-go-v2/issues/2336 for context.

References

See #37878 for the equivalent issue with dual-stack endpoints

Would you like to implement a fix?

None

github-actions[bot] commented 3 months ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue