The PR #34233 ignores the setting of use_fips_endpoint when a custom endpoint is configured on the provider. However, it does not handle the case when an endpoint is configured in the shared configuration file or using an environment variable.
PR #34233 also added a test to confirm that the default FIPS endpoint is returned when use_fips_endpoint is set and that the custom endpoint is returned without error when both a custom endpoint and use_fips_endpoint are set.
Additional validation is needed for the following combinations:
Use FIPS endpoint set on the provider, shared configuration file, or environment variable
No custom endpoint (returns default FIPS endpoint), custom endpoint set on the provider, shared configuration file, or environment variable, base endpoint set in shared configuration file or environment variable (#32649 suggests adding base endpoint configuration on the provider)
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
Volunteering to Work on This Issue
If you are interested in working on this issue, please leave a comment.
If this would be your first contribution, please review the contribution guide.
Description
The PR #34233 ignores the setting of
use_fips_endpoint
when a custom endpoint is configured on the provider. However, it does not handle the case when an endpoint is configured in the shared configuration file or using an environment variable.PR #34233 also added a test to confirm that the default FIPS endpoint is returned when
use_fips_endpoint
is set and that the custom endpoint is returned without error when both a custom endpoint anduse_fips_endpoint
are set.Additional validation is needed for the following combinations:
Note that this should not include validating that the FIPS endpoint returned is a routable address. See https://github.com/aws/aws-sdk-go-v2/issues/2336 for context.
References
See #37878 for the equivalent issue with dual-stack endpoints
Would you like to implement a fix?
None