hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.81k stars 9.16k forks source link

[Bug]: missing parameter in sqli_match_statement for Web ACL #38000

Closed prasad5501 closed 3 months ago

prasad5501 commented 4 months ago

Terraform Core Version

1.6.1

AWS Provider Version

5.54.1

Affected Resource(s)

aws_wafv2_rule_group

Expected Behavior

When using statement of type sqli_match_statement in rule while creating aws_wafv2_rule_group should support a parameter to set sensitivity as supported in underlying AWS api.

Actual Behavior

When using statement of type sqli_match_statement in rule while creating aws_wafv2_rule_group does not support a parameter to set sensitivity as supported in underlying AWS api.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

rule {
    name = "xyz"
    priority = 0

    action {
      block {}
    }

    statement {
      sqli_match_statement {
        text_transformation {
          type = "NONE"
          priority = 0
        }

        field_to_match {
          json_body {
            match_pattern {
              all {}
            }
            match_scope = "ALL"
            oversize_handling = "CONTINUE"
          }
        }
      }
    }
    visibility_config {
      cloudwatch_metrics_enabled = true
      metric_name = "xyz_metrics"
      sampled_requests_enabled = false
    }
  }

Steps to Reproduce

When a rule is created of type sqli_match_statement it defaults to low sensitivity. One needs to manually update it to HIGH from AWS console which is replaced on next terraform run.

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

No

github-actions[bot] commented 4 months ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

acwwat commented 3 months ago

I believe this has been fixed in v5.56.0 via #29672. The enhancement should also apply to the aws_wafv2_rule_group resource, and you should be able to set the sensitivity_level parameter.

However the documentation doesn't seem to have been updated, which I will do with this issue.

github-actions[bot] commented 3 months ago

[!WARNING] This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

github-actions[bot] commented 3 months ago

This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 2 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.