[Enhancement]: In names_data.hcl reverse skip_client_generate to skip_generate_client

[ThomasZalewski]

Description

Currently in names_data.hcl, skip_client_generate is a double negative when it is marked as false which should be avoided to make the file more clear and easier to read. This should be done by changing skip_client_generate to generate_client and marking services where generate_client is false with generate_client = false and excluding the attribute where it is true. Along with this change, names/README.md will have to be updated with this new schema.

Affected Resource(s) and/or Data Source(s)

names/data/names_data.hcl and generation of services

Potential Terraform Configuration

client {
    go_v1_client_typename = ""
    generate_client  = false
  }

References

https://github.com/hashicorp/terraform-provider-aws/pull/37960#discussion_r1640238136

Would you like to implement a fix?

None

[github-actions[bot]]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.