hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.61k stars 8.99k forks source link

[Enhancement]: Add jupyter_lab_app_settings block to default_space_settings in aws_sagemaker_domain #38150

Open philipgebus opened 4 days ago

philipgebus commented 4 days ago

Description

SageMaker Studio now supports Shared JupyterLab spaces. In order to configure custom lifecycle configuration scripts, images etc. for shared spaces, a jupyter_lab_app_settings block needs to be added to the aws_sagemaker_domain.default_space_settings block.

Affected Resource(s) and/or Data Source(s)

aws_sagemaker_domain

Potential Terraform Configuration

resource "aws_sagemaker_domain" "this" {
  # other attributes ...

  default_space_settings {
    jupyter_lab_app_settings {
      code_repository {
        repository_url = "https://github.com/my_repo"
      }
      default_resource_spec {
        instance_type        = "ml.t3.medium"
        lifecycle_config_arn = aws_sagemaker_studio_lifecycle_config.jupyterlab.arn
        # sagemaker_image_arn
        # sagemaker_image_version_alias
        # sagemaker_image_version_arn
      }
      lifecycle_config_arns = [aws_sagemaker_studio_lifecycle_config.jupyterlab.arn]
      custom_image {
        app_image_config_name = aws_sagemaker_app_image_config.jupyterlab.id
        image_name            = aws_sagemaker_image.jupyterlab.id
      }
    }
  }
}

References

  1. https://pkg.go.dev/github.com/aws/aws-sdk-go@v1.54.9/service/sagemaker#DefaultSpaceSettings
  2. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sagemaker/client/create_domain.html

Would you like to implement a fix?

No

github-actions[bot] commented 4 days ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue