hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.61k stars 9k forks source link

[Docs]: It was not mentioned that cidr_blocks and security_groups are ORed #38189

Open EugenKon opened 1 week ago

EugenKon commented 1 week ago

Documentation Link

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/security_group#ingress

Description

Terraform Version

NA

Affected Pages

What is the docs issue?

It does not mention, that separate rules are created for security_groups and cidr_blocks

  ingress {
    from_port   = 22
    to_port     = 22
    protocol    = "tcp"
    security_groups = "${var.client_vpn_sg}"
    cidr_blocks = local.allowlist_ip
  }

I suppose by mistake that inbound traffic should be from cidr_blocks AND from security_groups. But they are processed separately.

Proposal

Doc should clarify this.

References

https://github.com/hashicorp/terraform/issues/35398

References

No response

Would you like to implement a fix?

None

github-actions[bot] commented 1 week ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue