[Bug]: aws_securitylake_subscriber supports only one source

[MWEJ]

Terraform Core Version

1.9.2

AWS Provider Version

5.57.0

Affected Resource(s)

#Subscriber
resource "aws_securitylake_subscriber" "foo" {
  subscriber_name        = "foo"
  access_type            = "S3"
  subscriber_description = "Allow foo to access data"

  source {
    aws_log_source_resource {
      source_name    = "SH_FINDINGS"
      source_version = "2.0"
    }
    aws_log_source_resource {
       source_name    = "ROUTE53"
       source_version = "2.0"
    }
  }
  subscriber_identity {
    external_id = "foo"
    principal   = "000123456789"
  }
}

Expected Behavior

Sources should take an array of LogSourceResource objects. https://docs.aws.amazon.com/security-lake/latest/APIReference/API_CreateSubscriber.html

Actual Behavior

Error: Invalid Attribute Value │ │ with module.aws-security-lake.aws_securitylake_subscriber.foo, │ on ../../../src/main.tf line 181, in resource "aws_securitylake_subscriber" "foo": │ 181: resource "aws_securitylake_subscriber" "foo" { │ │ Attribute source[Value({"aws_log_source_resource":[{"source_name":"SH_FINDINGS","source_version":"2.0"},{"source_name":"ROUTE53","source_version":"2.0"}],"custom_log_source_resource":})].aws_log_source_resource list must contain at most 1 elements, got: 2 ╵ (base)

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

n/a

Steps to Reproduce

terraform init terraform plan

Debug Output

No response

Panic Output

No response

Important Factoids

This bug was previously reported as #36688 and fixed in v5.49.0, but I'm still experiencing this bug in v5.57.0

References

No response

Would you like to implement a fix?

None

[github-actions[bot]]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[justinretzolk]

Hey @MWEJ 👋 Thank you for taking the time to raise this! In this case, you'd specify multiple source blocks, rather than multiple aws_log_source_resource blocks within one source block. Updating your example would look like:

resource "aws_securitylake_subscriber" "foo" {
  subscriber_name        = "foo"
  access_type            = "S3"
  subscriber_description = "Allow foo to access data"

  source {
    aws_log_source_resource {
      source_name    = "SH_FINDINGS"
      source_version = "2.0"
    }
  }

  source {
    aws_log_source_resource {
       source_name    = "ROUTE53"
       source_version = "2.0"
    }
  }

  subscriber_identity {
    external_id = "foo"
    principal   = "000123456789"
  }
}

I've opened a pull request to update the documentation and make this a bit more clear.

[github-actions[bot]]

[!WARNING] This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions[bot]]

This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions[bot]]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.