hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.71k stars 9.07k forks source link

[Enhancement]: Add support for identity_center_configuration for redshift datasource #38347

Open enr0c opened 1 month ago

enr0c commented 1 month ago

Description

When creating a datasource from redshift to quicksight, the user has the option to enable the Identity Center Configuration, so that no user or password for the datasource has to be provided. This is documented here: https://docs.aws.amazon.com/quicksight/latest/APIReference/API_IdentityCenterConfiguration.html

This parameter is not available in https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/quicksight_data_source#redshift-argument-reference

Requested Resource(s) and/or Data Source(s)

aws_quicksight_data_source

Potential Terraform Configuration

Desired config:

resource "aws_quicksight_data_source" "redshift_idc_tip_datasource" {
  data_source_id = "21384ehczl120yu2sadf" 
  name = "redshift_idc_tip_datasource connection"
  type = "REDSHIFT"
  ssl_properties {
    disable_ssl = false

  }
  vpc_connection_properties {
    vpc_connection_arn = aws_quicksight_vpc_connection.qs_conn_to_vpc.arn
  }

  parameters  {
    redshift  {
      host     = "host"
      port     = 5439
      database = "dev"
/* 
the following parameters should be implemented - via: https://github.com/hashicorp/terraform-provider-aws/issues/38347
*/
      identity_center_configuration = {
        "enable_identity_propagation" = true
      }
    }
  }
}

Most probably here to be implemented/changed: https://github.com/hashicorp/terraform-provider-aws/blob/0660f7dc5b3b3ddad041047f3ea7a274b11dd24a/internal/service/quicksight/data_source.go#L362

Most probably also the cluster_id validation, to check if its not null should be changed. Redshift serverless does not have a cluster_id

References

https://docs.aws.amazon.com/quicksight/latest/APIReference/API_IdentityCenterConfiguration.html

Would you like to implement a fix?

No

github-actions[bot] commented 1 month ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue