hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.

https://registry.terraform.io/providers/hashicorp/aws

Mozilla Public License 2.0

9.73k stars 9.09k forks source link

Replace use of AWS SDK for Go v1 `private/protocol` functions #38380

Closed ewbankkit closed 1 week ago

ewbankkit commented 1 month ago

Various resources are making use of JSON functions in the github.com/aws/aws-sdk-go/private/protocol package. As part of AWS SDK for Go v2 migration we need to find or implement suitable replacements. For example int32 is not supported.

github-actions[bot] commented 1 month ago

Community Note

Voting for Prioritization

Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

If you are interested in working on this issue, please leave a comment.
If this would be your first contribution, please review the contribution guide.

ewbankkit commented 1 month ago

~I think we can use the functionality in github.com/aws/smithy-go/document/json.~

Judicious use of standard JSON decode/encode should be sufficient (at least for ECS #38016). Some handy wrappers added to internal/json.

ewbankkit commented 1 month ago

Look out for initial character capitalization for keys and inclusion of empty values.

github-actions[bot] commented 1 week ago

[!WARNING] This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

github-actions[bot] commented 1 week ago

This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!