hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.73k stars 9.09k forks source link

[Enhancement]: `aws_kinesis_firehose_delivery_stream`: add `api_url` to `http_endpoint_configuration` #38523

Open kesavaraju8 opened 1 month ago

kesavaraju8 commented 1 month ago

Terraform Core Version

1.7.5

AWS Provider Version

4.9

Affected Resource(s)

aws_kinesis_firehose_delivery_stream

Expected Behavior

since there is no separate block for dynatrace_configuration directly, we are using http_endpoint_configuration but we can use only option(URL) to provide the endpoint but in this special case we should pass two URL's

  1. http endpoint = https://aws.cloud.dynatrace.com
  2. Api URL = https://esn13524.live.dynatrace.com ( which is dynatrace endpoint)

But its not possible to pass two options

Actual Behavior

Either Dynatrace_configuration block added with http endpoint URL and dynatrace API_URL or directly http_endpoint_configuration should support both URL's

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

http_endpoint_configuration {
    url               = "https://aws.cloud.dynatrace.com"
   dynatrace_api_url  =  ?
    name              = "Dynatrace"
    access_key        = var.api_key
    role_arn          = aws_iam_role.firehose_role.arn
    s3_backup_mode    = "FailedDataOnly"

    s3_configuration {
      role_arn                = aws_iam_role.firehose_role.arn
      bucket_arn              = var.bucket_arn
      prefix                  = "firehose-backup/"
      buffering_size          = 5
      buffering_interval      = 300
      compression_format      = "GZIP"
    }
}

Steps to Reproduce

Terraform plan with http endpoint and dynatrace api URL

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

github-actions[bot] commented 1 month ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

justinretzolk commented 1 week ago

Hey @kesavaraju8 👋 Thanks for taking the time to raise this! We consider additions to existing resources to be an enhancement, rather than a bug. With that in mind, I'm going to update a few things about this issue. There's no further action needed from you at this point, I just like to let people know before making these kinds of modifications.