[Bug]: Apply must be run twice to deploy all resources

[cam-slyp]

Terraform Core Version

1.9.1, 1.9.3

AWS Provider Version

5.60.0

Affected Resource(s)

aws_lambda_function

Expected Behavior

When an sns topic and lambda environment variable referencing the topic arn are added, both the sns topic and lambda should be modified in a single apply

Actual Behavior

Two runs of apply are required to apply all changes

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

terraform {
  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = "5.60.0"
    }
  }

  required_version = "1.9.1"
}

provider "aws" {
  region = "ap-southeast-2"
}

resource "aws_iam_role" "iam_for_lambda" {
  name = "testing_tf_iam_role"

  managed_policy_arns = [
    "arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole"
  ]

  assume_role_policy = jsonencode({
    Version = "2012-10-17"
    Statement = [
      {
        Action = "sts:AssumeRole"
        Effect = "Allow"
        Principal = {
          Service = "lambda.amazonaws.com"
        }

      }
    ]
  })
}

resource "aws_lambda_function" "test_tf_lambda" {
  filename      = "lambda_src/lambdazip.zip"
  function_name = "testing_lambda"
  role          = aws_iam_role.iam_for_lambda.arn
  handler       = "index.handler"
  runtime       = "nodejs20.x"
  # environment {
  #   variables = {
  #     SNS_TOPIC_ARN = aws_sns_topic.test_tf_topic.arn
  #   }
  # }
}

# resource "aws_sns_topic" "test_tf_topic" {
#   name = "test_tf_topic"
# }

Steps to Reproduce

1. Run terraform apply to deploy role and lambda function
2. Uncomment both the commented sections
3. Run terraform apply

The diff will only show the topic creation, with no changes to the lambda

4. Run terraform apply

The diff will now show the changes to the lambda function

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

[github-actions[bot]]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[justinretzolk]

Similar #38755

[justinretzolk]

Whoops! Sorry about the closure!