Closed borela closed 2 days ago
Voting for Prioritization
Volunteering to Work on This Issue
The desired behavior for setting the minor version does not solve the problem.
With 3.13, automatic minor version upgrades are required (which is why we can't set the minor version). If terraform allows us to specify the minor version and that matches the latest, when a new minor version is released it will reintroduce the problem.
The expected behavior should be: When the automatic minor version upgrades are enabled and the major version matches, then terraform should not change the version.
@ofiesh That makes sense; your proposed solution would solve the problem much better.
Exactly the same problem with ActiveMQ where AWS enforces "auto minor updates" since version 5.18
(i.e. patch upgrades in version number) but the server still returns the patch version number. This means that any auto-patch from AWS will create a diff in Terraform -- which is a no-go for us.
We expect to specify 5.18
without the patch value in the engine_version
variable as auto minor version upgrades are enforced since this ActiveMQ version.
"BadRequestException: Brokers on [ActiveMQ] version [5.18] must have [autoMinorVersionUpgrade] set to [true]."
# The servers responds 5.18.4 after the upgrade.
# If we apply this, it triggers an update (i.e. reboot) of the cluster (which is not expected) but no version is changed (which is expected).
~ resource "aws_mq_broker" "activemq" {
~ engine_version = "5.18.4" -> "5.18"
Note that the aws_mq_configuration
does expects and returns 5.18
and will give an error if we try to specify the patch number when using version >= 5.18
. This behavior seems appropriate.
resource "aws_mq_configuration" "broker" {
engine_version = var.engine_version
We decided to tell Terraform to ignore changes until this issue is fixed.
lifecycle {
ignore_changes = [ engine_version ]
}
Similar #38708
Hi, I can work on this issue
@justinretzolk
The solution proposed by @ofiesh will additionally resolve issue #14705.
I reached out to AWS regarding this. Response was: -
With the introduction of compulsory automatic minor version upgrades for 5.18, where the service will always default to the next compatible and secure patch version upon broker creation/update, it would be expected for MQ to only allow you to select version 5.18 given the dynamic nature of this approach.
[!WARNING] This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.
Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.
Terraform Core Version
1.8.2-1
AWS Provider Version
5.63.0
Affected Resource(s)
aws_mq_broker
Expected Behavior
Allowed me to set engine version using the minor version too.
Actual Behavior
Keeps trying to set it to 3.13
But later, on the next apply, it notices AWS set it to 3.13.6
Relevant Error/Panic Output Snippet
No response
Terraform Configuration Files
If I try to set to 3.13.6, it gives an error.
Steps to Reproduce
Try to create any rabbitmq instance with the version 3.13.6
Debug Output
No response
Panic Output
No response
Important Factoids
No response
References
No response
Would you like to implement a fix?
None