hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.74k stars 9.1k forks source link

[Bug]: changing bootstrap configuration on existing EKS clusters should not trigger destroy/rebuild #38950

Closed iancward closed 1 week ago

iancward commented 3 weeks ago

Terraform Core Version

v1.5.5

AWS Provider Version

v5.63.1

Affected Resource(s)

Expected Behavior

Changing value for access_config.bootstrap_cluster_creator_admin_permissions on an existing cluster should not trigger cluster destroy/rebuild

Actual Behavior

Changing access_config.bootstrap_cluster_creator_admin_permissions on an existing cluster triggers cluster destroy/rebuild

Relevant Error/Panic Output Snippet

~ access_config {
          ~ bootstrap_cluster_creator_admin_permissions = false -> true # forces replacement
            # (1 unchanged attribute hidden)
        }

Terraform Configuration Files

resource "aws_eks_cluster" "control_plane" {
  name                      = "${var.prefix}-eks"
  ...

  # Enable aws-auth configuration via configmap AND API
  access_config {
    authentication_mode = "API_AND_CONFIG_MAP"
    # This should always be default true
    bootstrap_cluster_creator_admin_permissions = true
  }
}

Steps to Reproduce

Debug Output

No response

Panic Output

No response

Important Factoids

This came up in #35824, but wasn't fully addressed, because changing the value still triggers a destroy/re-create.

References

35824

Would you like to implement a fix?

None

github-actions[bot] commented 3 weeks ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

bryantbiggs commented 1 week ago

Duplicate of https://github.com/hashicorp/terraform-provider-aws/issues/38967

there isn't anything that Terraform can do for this - it is dictated by the EKS API - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-eks-cluster-accessconfig.html#cfn-eks-cluster-accessconfig-bootstrapclustercreatoradminpermissions

Update requires: Replacement

justinretzolk commented 1 week ago

I'm going to close this issue so that we can consolidate the conversation on #38967. Please direct any further updates to that issue.

github-actions[bot] commented 1 week ago

[!WARNING] This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.