hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.74k stars 9.1k forks source link

[Enhancement]: aws_cloudhsm_v2_cluster - add support for hsm2m.medium hsm_type #39018

Closed guiyang2011 closed 2 days ago

guiyang2011 commented 2 weeks ago

Description

The cloudhsm type "hsm2m.medium" was supported in aws-sdk-go v1.54.1, which had been added to the terraform-provider-aws already. However, it doesn't seem the current terraform-provider-aws exposes the new type yet https://github.com/hashicorp/terraform-provider-aws/blob/a89fe9b3017efc499d4b9d01c7c662266d884888/internal/service/cloudhsmv2/cluster.go#L91

Affected Resource(s) and/or Data Source(s)

aws_cloudhsm_v2_cluster

Potential Terraform Configuration

resource "aws_cloudhsm_v2_cluster" "cloudhsm_v2_cluster" {
  hsm_type   = "hsm2m.medium"
}

References

aws-sdk-go https://github.com/aws/aws-sdk-go/blob/02c1f723b528251a45068001bee8b56d904d7484/models/apis/cloudhsmv2/2017-04-28/docs-2.json#L382

Would you like to implement a fix?

None

github-actions[bot] commented 2 weeks ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

stefanfreitag commented 2 weeks ago

Hi @guiyang2011!

Thanks for reporting the issue. Let me have a look into this.

AWS Blog "AWS CloudHSM launches new hsm2m.medium instance type"

prestonprice57 commented 6 days ago

Hey I can take a crack at this one. PR incoming.

github-actions[bot] commented 2 days ago

[!WARNING] This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

github-actions[bot] commented 14 hours ago

This functionality has been released in v5.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!