hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.83k stars 9.18k forks source link

[Enhancement]: Changing display_name in identitystore_group should not force identitystore_group replacement. #39415

Closed jylitalo closed 1 month ago

jylitalo commented 1 month ago

Description

It should be possible to change identitystore_group's display_name with modify instead of destroy/apply.

Affected Resource(s) and/or Data Source(s)

Potential Terraform Configuration

Right now terraform claims that change in display_name forces replacement, even though group_id and identity_store_id are the only fields that are needed as keys in `resourceGroupUpdate()` function.
This is probably due to `ForceNew: true,` at https://github.com/hashicorp/terraform-provider-aws/blob/dd90468c8aec95815afca8e1aaa2b6d17d2098d2/internal/service/identitystore/group.go#L49C5-L49C24

References

You can change identitystore_group name with aws identitystore update-group --identity-store-id d-... --group-id ...-...-...-...-... --operations '[{ "AttributePath": "DisplayName","AttributeValue": "NewName" }]'

Would you like to implement a fix?

No

github-actions[bot] commented 1 month ago

Community Note

Voting for Prioritization

Volunteering to Work on This Issue

alex-gunning commented 1 month ago

Thank you for submitting something! This is a major issue for my company as well!

github-actions[bot] commented 1 month ago

[!WARNING] This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

github-actions[bot] commented 1 month ago

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 1 week ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.