hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.76k stars 9.12k forks source link

Use Go 1.23 `slices.Chunk` as a replacement for `internal/slices.Chunks`, redux #39475

Closed ewbankkit closed 2 days ago

ewbankkit commented 3 days ago

Description

Use the new Go 1.23 slices.Chunk function as a replacement for our internal/slices.Chunks.

Relations

Relates https://github.com/hashicorp/terraform-provider-aws/pull/39144. Relates https://github.com/hashicorp/terraform-provider-aws/pull/39256. Relates https://github.com/hashicorp/terraform-provider-aws/pull/39432.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withTrafficSourcesELBs\|TestAccAutoScalingGroup_loadBalancers\|TestAccAutoScalingGroup_targetGroups' PKG=autoscaling ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingGroup_basic\|TestAccAutoScalingGroup_withTrafficSourcesELBs\|TestAccAutoScalingGroup_loadBalancers\|TestAccAutoScalingGroup_targetGroups -timeout 360m
=== RUN   TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== RUN   TestAccAutoScalingGroup_withTrafficSourcesELBs
=== PAUSE TestAccAutoScalingGroup_withTrafficSourcesELBs
=== RUN   TestAccAutoScalingGroup_loadBalancers
=== PAUSE TestAccAutoScalingGroup_loadBalancers
=== RUN   TestAccAutoScalingGroup_targetGroups
=== PAUSE TestAccAutoScalingGroup_targetGroups
=== CONT  TestAccAutoScalingGroup_basic
=== CONT  TestAccAutoScalingGroup_loadBalancers
--- PASS: TestAccAutoScalingGroup_basic (71.10s)
=== CONT  TestAccAutoScalingGroup_targetGroups
--- PASS: TestAccAutoScalingGroup_targetGroups (186.18s)
=== CONT  TestAccAutoScalingGroup_withTrafficSourcesELBs
--- PASS: TestAccAutoScalingGroup_loadBalancers (417.76s)
--- PASS: TestAccAutoScalingGroup_withTrafficSourcesELBs (227.89s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling    490.643s
github-actions[bot] commented 3 days ago

Community Note

Voting for Prioritization

For Submitters

github-actions[bot] commented 1 day ago

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!