hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.76k stars 9.12k forks source link

New Resource: aws_ec2_transit_gateway_default_route_table_association #39496

Open drewtul opened 1 day ago

drewtul commented 1 day ago

Description

New resource aws_ec2_transit_gateway_default_route_table_association that allows you to manage setting the default route table for associations on a transit gateway.

Relations

Relates #35085 creates one of the two resources required to fix this.

References

Output from Acceptance Testing

% make testacc TESTS='TestAccTransitGateway_serial/DefaultRouteTableAssociation_' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccTransitGateway_serial/DefaultRouteTableAssociation_'  -timeout 360m
=== RUN   TestAccTransitGateway_serial
=== PAUSE TestAccTransitGateway_serial
=== CONT  TestAccTransitGateway_serial
=== RUN   TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears
=== RUN   TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
=== PAUSE TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
=== CONT  TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears
=== CONT  TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic
--- PASS: TestAccTransitGateway_serial (0.00s)
    --- PASS: TestAccTransitGateway_serial/DefaultRouteTableAssociation_basic (210.17s)
    --- PASS: TestAccTransitGateway_serial/DefaultRouteTableAssociation_disappears (210.38s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        215.675s
github-actions[bot] commented 1 day ago

Community Note

Voting for Prioritization

For Submitters

drewtul commented 1 day ago

I believe the failing checks are false positives for this change at least.

ewbankkit commented 4 hours ago
% make golangci-lint PKG=ec2
make: golangci-lint Checks / 1 of 3...
make: golangci-lint Checks / 2 of 3...
WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`. 
make: golangci-lint Checks / 3 of 3...
ewbankkit commented 3 hours ago

@drewtul Thanks for the contribution :tada: :clap:.