ewbankkit commented 1 month ago

Description

Tag on Create for the aws_kinesis_stream resource.

Relations

Closes https://github.com/hashicorp/terraform-provider-aws/issues/39502.

Output from Acceptance Testing

AWS Standard

% make testacc TESTARGS='-run=TestAccKinesisStream_basic\|TestAccKinesisStream_tags' PKG=kinesis
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/kinesis/... -v -count 1 -parallel 20  -run=TestAccKinesisStream_basic\|TestAccKinesisStream_tags -timeout 360m
=== RUN   TestAccKinesisStream_basic
=== PAUSE TestAccKinesisStream_basic
=== RUN   TestAccKinesisStream_tags
=== PAUSE TestAccKinesisStream_tags
=== RUN   TestAccKinesisStream_basicOnDemand
=== PAUSE TestAccKinesisStream_basicOnDemand
=== CONT  TestAccKinesisStream_basic
=== CONT  TestAccKinesisStream_basicOnDemand
=== CONT  TestAccKinesisStream_tags
--- PASS: TestAccKinesisStream_basic (45.69s)
--- PASS: TestAccKinesisStream_basicOnDemand (45.96s)
--- PASS: TestAccKinesisStream_tags (62.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesis    67.834s

AWS US GovCloud

% make testacc TESTARGS='-run=TestAccKinesisStream_basic\|TestAccKinesisStream_tags' PKG=kinesis
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/kinesis/... -v -count 1 -parallel 20  -run=TestAccKinesisStream_basic\|TestAccKinesisStream_tags -timeout 360m
=== RUN   TestAccKinesisStream_basic
=== PAUSE TestAccKinesisStream_basic
=== RUN   TestAccKinesisStream_tags
=== PAUSE TestAccKinesisStream_tags
=== RUN   TestAccKinesisStream_basicOnDemand
=== PAUSE TestAccKinesisStream_basicOnDemand
=== CONT  TestAccKinesisStream_basic
=== CONT  TestAccKinesisStream_basicOnDemand
=== CONT  TestAccKinesisStream_tags
--- PASS: TestAccKinesisStream_basicOnDemand (45.63s)
--- PASS: TestAccKinesisStream_basic (45.73s)
--- PASS: TestAccKinesisStream_tags (62.05s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kinesis    67.353s

github-actions[bot] commented 1 month ago

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions[bot] commented 1 month ago

This functionality has been released in v5.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions[bot] commented 2 weeks ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

hashicorp / terraform-provider-aws