AWS WAF Bot Control Rule Defaults

[RoseSecurity]

Description

Hey team, quick question about the AWS WAF's aws_managed_rules_bot_control_rule_set default values. From my understanding, inspection_levels can be one of two values, COMMON or TARGETED. This value is required but no default is assigned. For the enable_machine_learning parameter, it defaults to true, although this value is only compatible with TARGETED inspection levels. Should this be corrected to default to false?

Code Reference

"aws_managed_rules_bot_control_rule_set": {
    Type:     schema.TypeList,
    Optional: true,
    MaxItems: 1,
    Elem: &schema.Resource{
        Schema: map[string]*schema.Schema{
            "enable_machine_learning": {
                Type:     schema.TypeBool,
                Optional: true,
                Default:  true,
            },
            "inspection_level": {
                Type:             schema.TypeString,
                Required:         true,
                ValidateDiagFunc: enum.Validate[awstypes.InspectionLevel](),
            },
        },
    },
},

References

• AWS Documentation
• Code Reference

Would you like to implement a fix?

Yes

[github-actions[bot]]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.