hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.84k stars 9.19k forks source link

Tech debt: Remove AWS SDK for Go v1 support from `internal/generate/tags` #39913

Closed ewbankkit closed 2 weeks ago

ewbankkit commented 2 weeks ago

Description

Removes AWS SDK for Go v1 from the internal/generate/tags generator.

Relations

Relates https://github.com/hashicorp/terraform-provider-aws/pull/39280. Relates https://github.com/hashicorp/terraform-provider-aws/pull/39840. Relates https://github.com/hashicorp/terraform-provider-aws/issues/32976.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSecretsManagerSecretsDataSource_' PKG=secretsmanager
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/secretsmanager/... -v -count 1 -parallel 20  -run=TestAccSecretsManagerSecretsDataSource_ -timeout 360m
2024/10/28 16:43:52 Initializing Terraform AWS Provider...
=== RUN   TestAccSecretsManagerSecretsDataSource_filter
=== PAUSE TestAccSecretsManagerSecretsDataSource_filter
=== CONT  TestAccSecretsManagerSecretsDataSource_filter
--- PASS: TestAccSecretsManagerSecretsDataSource_filter (47.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager 52.683s
github-actions[bot] commented 2 weeks ago

Community Note

Voting for Prioritization

For Submitters

github-actions[bot] commented 2 weeks ago

This functionality has been released in v5.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!