hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.

https://registry.terraform.io/providers/hashicorp/aws

Mozilla Public License 2.0

9.84k stars 9.19k forks source link

d/aws_imagebuilder_image_recipe: Fix `block_device_mapping.0.ebs.0.delete_on_termination: '' expected type 'bool', got unconvertible type 'string', value: 'true'` #39928

Closed ewbankkit closed 2 weeks ago

ewbankkit commented 2 weeks ago

Description

Synch resource and data source types for the block_device_mapping.ebs block.

Relations

Closes https://github.com/hashicorp/terraform-provider-aws/issues/39927.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccImageBuilderImageRecipeDataSource_' PKG=imagebuilder
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/imagebuilder/... -v -count 1 -parallel 20  -run=TestAccImageBuilderImageRecipeDataSource_ -timeout 360m
2024/10/29 11:04:45 Initializing Terraform AWS Provider...
=== RUN   TestAccImageBuilderImageRecipeDataSource_arn
=== PAUSE TestAccImageBuilderImageRecipeDataSource_arn
=== CONT  TestAccImageBuilderImageRecipeDataSource_arn
--- PASS: TestAccImageBuilderImageRecipeDataSource_arn (16.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder   22.268s

github-actions[bot] commented 2 weeks ago

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions[bot] commented 2 weeks ago

This functionality has been released in v5.74.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!