fix(aws_bedrockagent_agent): argument instruction is mandatory

[jeremychauvet]

Description

This PR aims to set the argument instruction to be mandatory. While reviewing the AWS API reference, it appears this argument is marked as optional. However, in real-world usage, omitting it leads to the following issue:

│ Error: creating Agent
│
│   with aws_bedrockagent_agent.demo,
│   on agent.tf line 46, in resource "aws_bedrockagent_agent" "demo":
│   46: resource "aws_bedrockagent_agent" "demo" {
│
│ waiting for Bedrock Agent (3TTM4DCSXX) prepare: unexpected state 'FAILED', wanted target 'PREPARED'. last error: Exception: Agent Instruction cannot be null

Here's the source code related to this error message:

resource "aws_bedrockagent_agent" "demo" {
  agent_name              = "my-agent-name"
  agent_resource_role_arn = aws_iam_role.example.arn
  foundation_model        = "anthropic.claude-v2"
}

Relations

Closes #40255

References

(https://docs.aws.amazon.com/bedrock/latest/APIReference/API_agent_CreateAgent.html#API_agent_CreateAgent_RequestSyntax)

Output from Acceptance Testing

make testacc TESTS=TestAccBedrockAgentAgent_basic PKG=bedrockagent
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgentAgent_basic'  -timeout 360m
2024/11/22 10:11:54 Initializing Terraform AWS Provider...
=== RUN   TestAccBedrockAgentAgent_basic
=== PAUSE TestAccBedrockAgentAgent_basic
=== CONT  TestAccBedrockAgentAgent_basic
--- PASS: TestAccBedrockAgentAgent_basic (28.75s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       28.844s

[github-actions[bot]]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.