search

hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.76k stars 9.12k forks source link

Feature Request: import support for aws_kinesis_firehose_delivery_stream #481

Closed hashibot closed 6 years ago

hashibot commented 7 years ago

This issue was originally opened by @grep-stripe as hashicorp/terraform#11366. It was migrated here as part of the provider split. The original body of the issue is below.

Terraform Version

terraform -v Terraform v0.8.4

Affected Resource(s)

aws_kinesis_firehose_delivery_stream

Terraform Configuration Files

The relevant portion of the configuration file.

resource "aws_kinesis_firehose_delivery_stream" "flow_logs_delivery_stream" {
  name        = "flowlogs-kinesis-firehose-s3-stream"
  destination = "s3"

  s3_configuration {
    role_arn   = "${aws_iam_role.firehose_role.arn}"
    bucket_arn = "${aws_s3_bucket.flow_logs_s3_bucket.arn}"
  }
}

Feature Request

Please support terraform import for the aws_kinesis_delivery_stream resource.

$ sc-terraform import aws_kinesis_firehose_delivery_stream.flow_logs_delivery_stream flowlogs-kinesis-firehose-s3-stream
aws_kinesis_firehose_delivery_stream.flow_logs_delivery_stream: Importing from ID "flowlogs-kinesis-firehose-s3-stream"...
Error importing: 1 error(s) occurred:

* import aws_kinesis_firehose_delivery_stream.flow_logs_delivery_stream (id: flowlogs-kinesis-firehose-s3-stream): resource aws_kinesis_firehose_delivery_stream doesn't support import
docmerlin commented 6 years ago

bump If state gets messed up, it is annoying to fix without import

bflad commented 6 years ago

I believe this was just resolved in the next provider release by #2082.

bflad commented 6 years ago

This has been released in terraform-provider-aws version 1.7.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

bflad commented 6 years ago

For anything relating to enhancing the other portions of importing this resource, please open new specific issues. Thanks!

bflad commented 6 years ago

v1.7.0 added the initial functionality and v1.7.1 (hopefully releasing tomorrow) will contain important bug fixes for this implementation (#2970, #3052). I'm going to close this issue out now, but please do not hesitate to open new issues with any additional bug reports or other enhancements.

ghost commented 4 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!