YakDriver
commented
6 years ago After #6401, #6402, #6403, #6408 this is what is left (437 of 549 remain, 80%):
aws/autoscaling_tags.go:281:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/config_test.go:71:3:warning: redundant return statement (S1023) (gosimple)
aws/data_source_aws_ami_ids.go:64:81:warning: should omit comparison to bool constant, can be simplified to !ownersOk (S1002) (gosimple)
aws/data_source_aws_ami_ids.go:64:57:warning: should omit comparison to bool constant, can be simplified to !nameRegexOk (S1002) (gosimple)
aws/data_source_aws_ami_ids.go:64:35:warning: should omit comparison to bool constant, can be simplified to !filtersOk (S1002) (gosimple)
aws/data_source_aws_ami_ids.go:64:5:warning: should omit comparison to bool constant, can be simplified to !executableUsersOk (S1002) (gosimple)
aws/data_source_aws_autoscaling_groups.go:122:37:warning: should use make([]*autoscaling.Filter, len(in)) instead (S1019) (gosimple)
aws/data_source_aws_autoscaling_groups_test.go:53:6:warning: should omit comparison to bool constant, can be simplified to !reflect.DeepEqual(expected, actual) (S1002) (gosimple)
aws/data_source_aws_availability_zones_test.go:62:6:warning: should omit comparison to bool constant, can be simplified to !reflect.DeepEqual(expected, actual) (S1002) (gosimple)
aws/data_source_aws_availability_zones_test.go:85:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/data_source_aws_availability_zones_test.go:85:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/data_source_aws_cloudwatch_log_group_test.go:28:2:warning: redundant return statement (S1023) (gosimple)
aws/data_source_aws_db_event_categories_test.go:65:6:warning: should omit comparison to bool constant, can be simplified to !reflect.DeepEqual(expected, actual) (S1002) (gosimple)
aws/data_source_aws_ebs_snapshot.go:153:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/data_source_aws_ebs_snapshot_ids.go:48:55:warning: should omit comparison to bool constant, can be simplified to !ownersOk (S1002) (gosimple)
aws/data_source_aws_ebs_snapshot_ids.go:48:33:warning: should omit comparison to bool constant, can be simplified to !filtersOk (S1002) (gosimple)
aws/data_source_aws_ebs_volume.go:147:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/data_source_aws_ecr_repository_test.go:20:79:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/data_source_aws_ecr_repository_test.go:22:90:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/data_source_aws_efs_file_system.go:97:3:warning: should replace loop with tags = append(tags, tagsResp.Tags...) (S1011) (gosimple)
aws/data_source_aws_efs_file_system.go:144:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/data_source_aws_efs_file_system_test.go:23:95:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/data_source_aws_efs_file_system_test.go:24:83:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/data_source_aws_elasticache_cluster.go:209:39:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/data_source_aws_instance.go:258:52:warning: should omit comparison to bool constant, can be simplified to !tagsOk (S1002) (gosimple)
aws/data_source_aws_instance.go:258:27:warning: should omit comparison to bool constant, can be simplified to !instanceIDOk (S1002) (gosimple)
aws/data_source_aws_instance.go:258:5:warning: should omit comparison to bool constant, can be simplified to !filtersOk (S1002) (gosimple)
aws/data_source_aws_instances.go:128:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/data_source_aws_internet_gateway.go:81:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/data_source_aws_route53_zone.go:99:110:warning: should omit comparison to bool constant, can be simplified to *hostedZone.Config.PrivateZone (S1002) (gosimple)
aws/data_source_aws_s3_bucket.go:75:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/data_source_aws_s3_bucket_object.go:137:32:warning: should omit comparison to bool constant, can be simplified to *out.DeleteMarker (S1002) (gosimple)
aws/data_source_aws_s3_bucket_object_test.go:110:7:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/data_source_aws_security_groups.go:89:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/ecs_task_definition_equivalency.go:48:11:warning: should use bytes.Equal(canonicalJson1, canonicalJson2) instead (S1004) (gosimple)
aws/import_aws_db_event_subscription.go:13:42:warning: should use make([]*schema.ResourceData, 1) instead (S1019) (gosimple)
aws/import_aws_s3_bucket.go:16:42:warning: should use make([]*schema.ResourceData, 1) instead (S1019) (gosimple)
aws/resource_aws_acmpca_certificate_authority.go:705:3:warning: should replace loop with tags = append(tags, output.Tags...) (S1011) (gosimple)
aws/resource_aws_acmpca_certificate_authority_test.go:463:3:warning: should replace loop with certificateAuthorities = append(certificateAuthorities, output.CertificateAuthorities...) (S1011) (gosimple)
aws/resource_aws_ami_launch_permission_test.go:196:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ami_launch_permission_test.go:196:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ami_launch_permission_test.go:231:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ami_launch_permission_test.go:231:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_api_gateway_documentation_part.go:171:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_api_gateway_documentation_part.go:206:36:warning: should use make(map[string]interface{}) instead (S1019) (gosimple)
aws/resource_aws_api_gateway_method_response_test.go:70:7:warning: should omit comparison to bool constant, can be simplified to !*val (S1002) (gosimple)
aws/resource_aws_api_gateway_method_test.go:210:7:warning: should omit comparison to bool constant, can be simplified to *val (S1002) (gosimple)
aws/resource_aws_api_gateway_method_test.go:217:7:warning: should omit comparison to bool constant, can be simplified to !*val (S1002) (gosimple)
aws/resource_aws_api_gateway_method_test.go:237:7:warning: should omit comparison to bool constant, can be simplified to *val (S1002) (gosimple)
aws/resource_aws_api_gateway_stage.go:145:40:warning: should use make(map[string]string) instead (S1019) (gosimple)
aws/resource_aws_api_gateway_vpc_link.go:190:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_api_gateway_vpc_link_test.go:103:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_api_gateway_vpc_link_test.go:103:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_app_cookie_stickiness_policy_test.go:134:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_app_cookie_stickiness_policy_test.go:134:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_appautoscaling_policy.go:458:66:warning: should use make([]*applicationautoscaling.MetricDimension, s.Len()) instead (S1019) (gosimple)
aws/resource_aws_appautoscaling_policy.go:638:36:warning: should use make(map[string]interface{}) instead (S1019) (gosimple)
aws/resource_aws_appautoscaling_policy.go:660:29:warning: should use make([]interface{}, len(adjs)) instead (S1019) (gosimple)
aws/resource_aws_appautoscaling_policy.go:663:37:warning: should use make(map[string]interface{}) instead (S1019) (gosimple)
aws/resource_aws_appautoscaling_policy.go:685:36:warning: should use make(map[string]interface{}) instead (S1019) (gosimple)
aws/resource_aws_appautoscaling_policy.go:729:27:warning: should use make([]interface{}, len(ds)) instead (S1019) (gosimple)
aws/resource_aws_appsync_graphql_api_test.go:560:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_appsync_graphql_api_test.go:560:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_athena_database_test.go:252:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_athena_database_test.go:252:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_athena_database_test.go:285:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_athena_database_test.go:285:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_athena_named_query.go:98:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_athena_named_query_test.go:90:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_athena_named_query_test.go:90:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_autoscaling_group.go:964:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_autoscaling_group.go:980:2:warning: 'if metricsErr != nil { return metricsErr }; return nil' can be simplified to 'return metricsErr' (S1013) (gosimple)
aws/resource_aws_autoscaling_group_waiting.go:118:19:warning: should use String() instead of fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_autoscaling_notification.go:197:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_autoscaling_schedule_test.go:66:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_autoscaling_schedule_test.go:66:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_autoscaling_schedule_test.go:163:3:warning: should write autoScalingGroup := rs.Primary.Attributes["autoscaling_group_name"] instead of autoScalingGroup, _ := rs.Primary.Attributes["autoscaling_group_name"] (S1005) (gosimple)
aws/resource_aws_autoscaling_schedule_test.go:192:3:warning: should write autoScalingGroup := rs.Primary.Attributes["autoscaling_group_name"] instead of autoScalingGroup, _ := rs.Primary.Attributes["autoscaling_group_name"] (S1005) (gosimple)
aws/resource_aws_cloud9_environment_ec2.go:226:2:warning: 'if err != nil { return err }; return err' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cloudtrail_test.go:246:14:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_cloudwatch_event_permission_test.go:284:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cloudwatch_event_permission_test.go:284:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cloudwatch_event_rule.go:103:14:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_cloudwatch_event_rule.go:193:14:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_cloudwatch_log_group.go:120:34:warning: should use make(map[string]string) instead (S1019) (gosimple)
aws/resource_aws_cloudwatch_log_group_test.go:282:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cloudwatch_log_group_test.go:282:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cloudwatch_log_stream_test.go:61:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cloudwatch_log_stream_test.go:61:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cloudwatch_log_subscription_filter_test.go:69:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cloudwatch_log_subscription_filter_test.go:69:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cloudwatch_log_subscription_filter_test.go:84:3:warning: should write logGroupName := rs.Primary.Attributes["log_group_name"] instead of logGroupName, _ := rs.Primary.Attributes["log_group_name"] (S1005) (gosimple)
aws/resource_aws_cloudwatch_log_subscription_filter_test.go:85:3:warning: should write filterNamePrefix := rs.Primary.Attributes["name"] instead of filterNamePrefix, _ := rs.Primary.Attributes["name"] (S1005) (gosimple)
aws/resource_aws_cloudwatch_log_subscription_filter_test.go:117:3:warning: should write logGroupName := rs.Primary.Attributes["log_group_name"] instead of logGroupName, _ := rs.Primary.Attributes["log_group_name"] (S1005) (gosimple)
aws/resource_aws_cloudwatch_log_subscription_filter_test.go:118:3:warning: should write filterNamePrefix := rs.Primary.Attributes["name"] instead of filterNamePrefix, _ := rs.Primary.Attributes["name"] (S1005) (gosimple)
aws/resource_aws_codebuild_project.go:926:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_codecommit_trigger.go:127:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_codedeploy_deployment_config.go:121:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_codedeploy_deployment_group.go:665:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_codedeploy_deployment_group.go:1035:23:warning: should omit comparison to bool constant, can be simplified to *config.Enabled (S1002) (gosimple)
aws/resource_aws_codedeploy_deployment_group.go:1052:23:warning: should omit comparison to bool constant, can be simplified to *config.Enabled (S1002) (gosimple)
aws/resource_aws_codedeploy_deployment_group.go:1203:2:warning: should merge variable declaration with assignment on next line (S1021) (gosimple)
aws/resource_aws_codepipeline.go:478:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_codepipeline_test.go:155:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_codepipeline_test.go:155:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_codepipeline_webhook.go:121:3:warning: redundant break statement (S1023) (gosimple)
aws/resource_aws_codepipeline_webhook.go:124:3:warning: redundant break statement (S1023) (gosimple)
aws/resource_aws_codepipeline_webhook_test.go:124:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_codepipeline_webhook_test.go:124:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cognito_identity_pool_roles_attachment_test.go:18:10:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_identity_pool_roles_attachment_test.go:19:17:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_identity_pool_roles_attachment_test.go:47:10:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_identity_pool_roles_attachment_test.go:95:10:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_identity_pool_roles_attachment_test.go:111:10:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_identity_pool_roles_attachment_test.go:127:10:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_identity_pool_roles_attachment_test.go:159:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cognito_identity_pool_roles_attachment_test.go:159:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cognito_identity_pool_test.go:40:10:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_identity_pool_test.go:41:17:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_identity_pool_test.go:70:10:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_identity_pool_test.go:106:10:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_identity_pool_test.go:141:10:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_identity_pool_test.go:177:10:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_identity_pool_test.go:235:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cognito_identity_pool_test.go:235:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cognito_user_group_test.go:30:76:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_user_group_test.go:37:76:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_user_group_test.go:58:76:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_user_group_test.go:68:76:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_cognito_user_group_test.go:147:11:warning: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (S1028) (gosimple)
aws/resource_aws_cognito_user_group_test.go:159:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cognito_user_group_test.go:159:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cognito_user_pool_client_test.go:258:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cognito_user_pool_client_test.go:258:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cognito_user_pool_domain_test.go:111:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cognito_user_pool_domain_test.go:111:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cognito_user_pool_test.go:111:7:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_cognito_user_pool_test.go:113:7:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_cognito_user_pool_test.go:692:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_cognito_user_pool_test.go:692:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_config_aggregate_authorization.go:123:3:warning: should replace loop with aggregationAuthorizations = append(aggregationAuthorizations, output.AggregationAuthorizations...) (S1011) (gosimple)
aws/resource_aws_config_aggregate_authorization_test.go:73:90:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_config_configuration_aggregator_test.go:83:130:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_config_configuration_aggregator_test.go:114:130:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_customer_gateway.go:277:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_dax_cluster.go:295:39:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_dax_cluster_test.go:101:38:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_dax_cluster_test.go:103:47:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_dax_cluster_test.go:105:47:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_dax_cluster_test.go:115:53:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_dax_cluster_test.go:119:45:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_dax_cluster_test.go:121:57:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_dax_cluster_test.go:125:39:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_dax_parameter_group_test.go:94:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_dax_parameter_group_test.go:94:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_dax_subnet_group_test.go:82:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_dax_subnet_group_test.go:82:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_db_instance.go:1261:5:warning: should omit comparison to bool constant, can be simplified to !skipFinalSnapshot (S1002) (gosimple)
aws/resource_aws_db_snapshot.go:181:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_default_network_acl.go:278:6:warning: should omit comparison to bool constant, can be simplified to *e.Egress (S1002) (gosimple)
aws/resource_aws_directory_service_conditional_forwarder.go:47:42:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_dlm_lifecycle_policy.go:247:41:warning: should use make(map[string]interface{}) instead (S1019) (gosimple)
aws/resource_aws_dms_certificate.go:117:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_dms_replication_subnet_group.go:166:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_dms_replication_task.go:277:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_dx_connection.go:120:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_dx_hosted_private_virtual_interface_accepter.go:123:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_dx_hosted_public_virtual_interface_accepter.go:97:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_dx_lag.go:139:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_dx_private_virtual_interface.go:192:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_dx_public_virtual_interface.go:163:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_dynamodb_global_table.go:132:3:warning: should replace loop with replicaUpdates = append(replicaUpdates, replicaUpdateCreateReplicas...) (S1011) (gosimple)
aws/resource_aws_dynamodb_global_table.go:135:3:warning: should replace loop with replicaUpdates = append(replicaUpdates, replicaUpdateDeleteReplicas...) (S1011) (gosimple)
aws/resource_aws_dynamodb_global_table.go:250:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ebs_snapshot_copy_test.go:89:7:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_ebs_snapshot_test.go:100:7:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_ebs_volume_test.go:158:14:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_ec2_fleet.go:242:9:warning: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008) (gosimple)
aws/resource_aws_ec2_fleet.go:273:9:warning: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008) (gosimple)
aws/resource_aws_ecr_lifecycle_policy_test.go:97:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ecr_lifecycle_policy_test.go:97:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ecs_service.go:52:6:warning: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008) (gosimple)
aws/resource_aws_ecs_service.go:193:9:warning: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008) (gosimple)
aws/resource_aws_ecs_service.go:241:9:warning: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008) (gosimple)
aws/resource_aws_efs_file_system.go:258:3:warning: should replace loop with tags = append(tags, tagsResp.Tags...) (S1011) (gosimple)
aws/resource_aws_efs_file_system.go:305:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_efs_file_system_test.go:40:2:warning: should merge variable declaration with assignment on next line (S1021) (gosimple)
aws/resource_aws_efs_file_system_test.go:181:14:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_efs_file_system_test.go:323:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_efs_file_system_test.go:323:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_efs_mount_target.go:225:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_efs_mount_target_test.go:131:2:warning: should merge variable declaration with assignment on next line (S1021) (gosimple)
aws/resource_aws_eip_association_test.go:161:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_eip_association_test.go:161:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_elastic_beanstalk_application_version.go:136:5:warning: should omit comparison to bool constant, can be simplified to !d.Get("force_delete").(bool) (S1002) (gosimple)
aws/resource_aws_elastic_transcoder_pipeline.go:238:5:warning: should omit nil check; len() for nil slices is defined as zero (S1009) (gosimple)
aws/resource_aws_elastic_transcoder_pipeline_test.go:42:14:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_elasticache_cluster.go:441:40:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_elasticache_replication_group_test.go:616:6:warning: should merge variable declaration with assignment on next line (S1021) (gosimple)
aws/resource_aws_elasticsearch_domain.go:734:6:warning: should omit comparison to bool constant, can be simplified to !*out.DomainStatus.Processing (S1002) (gosimple)
aws/resource_aws_elasticsearch_domain_policy.go:80:6:warning: should omit comparison to bool constant, can be simplified to !*out.DomainStatus.Processing (S1002) (gosimple)
aws/resource_aws_elasticsearch_domain_policy.go:114:6:warning: should omit comparison to bool constant, can be simplified to !*out.DomainStatus.Processing (S1002) (gosimple)
aws/resource_aws_elasticsearch_domain_policy.go:121:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_elb.go:947:3:warning: redundant break statement (S1023) (gosimple)
aws/resource_aws_elb.go:962:3:warning: redundant break statement (S1023) (gosimple)
aws/resource_aws_elb.go:1032:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_emr_cluster.go:1162:25:warning: should use make([]*string, len(remove)) instead (S1019) (gosimple)
aws/resource_aws_emr_instance_group.go:208:4:warning: should replace loop with groups = append(groups, respGrps.InstanceGroups...) (S1011) (gosimple)
aws/resource_aws_emr_instance_group.go:312:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_gamelift_alias.go:138:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_gamelift_alias.go:171:36:warning: should use make(map[string]interface{}) instead (S1019) (gosimple)
aws/resource_aws_gamelift_build.go:176:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_gamelift_fleet.go:418:42:warning: should use make([]*gamelift.IpPermission, len(cfgs)) instead (S1019) (gosimple)
aws/resource_aws_gamelift_fleet.go:457:36:warning: should use make(map[string]interface{}) instead (S1019) (gosimple)
aws/resource_aws_gamelift_fleet.go:489:47:warning: should use make([]*gamelift.ServerProcess, len(cfgs)) instead (S1019) (gosimple)
aws/resource_aws_glacier_vault.go:409:48:warning: should use make(map[string]interface{}) instead (S1019) (gosimple)
aws/resource_aws_glue_crawler.go:288:40:warning: should use make([]*glue.DynamoDBTarget, len(targets)) instead (S1019) (gosimple)
aws/resource_aws_glue_crawler.go:309:34:warning: should use make([]*glue.S3Target, len(targets)) instead (S1019) (gosimple)
aws/resource_aws_glue_crawler.go:333:36:warning: should use make([]*glue.JdbcTarget, len(targets)) instead (S1019) (gosimple)
aws/resource_aws_guardduty_ipset_test.go:130:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_guardduty_ipset_test.go:130:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_guardduty_threatintelset_test.go:130:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_guardduty_threatintelset_test.go:130:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_group_membership.go:133:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_group_policy_attachment.go:109:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_group_policy_attachment.go:120:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_instance_profile.go:55:10:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_iam_instance_profile.go:75:10:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_iam_instance_profile.go:125:25:warning: should omit comparison to bool constant, can be simplified to !hasRoles (S1002) (gosimple)
aws/resource_aws_iam_instance_profile.go:125:5:warning: should omit comparison to bool constant, can be simplified to !hasRole (S1002) (gosimple)
aws/resource_aws_iam_instance_profile.go:345:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_openid_connect_provider_test.go:157:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_openid_connect_provider_test.go:157:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_policy.go:57:10:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_iam_policy.go:76:10:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_iam_policy.go:286:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_policy_attachment.go:220:3:warning: should merge variable declaration with assignment on next line (S1021) (gosimple)
aws/resource_aws_iam_role.go:52:10:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_iam_role.go:72:10:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_iam_role.go:361:4:warning: should replace loop with inlinePolicies = append(inlinePolicies, page.PolicyNames...) (S1011) (gosimple)
aws/resource_aws_iam_role_policy_attachment.go:131:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_role_policy_attachment.go:142:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_saml_provider_test.go:93:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_saml_provider_test.go:93:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_server_certificate.go:186:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_user_group_membership.go:131:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_user_login_profile.go:106:2:warning: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008) (gosimple)
aws/resource_aws_iam_user_policy_attachment.go:108:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_user_policy_attachment.go:119:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_user_policy_test.go:271:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_iam_user_policy_test.go:271:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_instance.go:1209:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_internet_gateway.go:369:6:warning: should use time.Since instead of time.Now().Sub (S1012) (gosimple)
aws/resource_aws_iot_topic_rule.go:608:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_kinesis_firehose_delivery_stream.go:545:36:warning: should use make([]interface{}, len(pc.Processors)) instead (S1019) (gosimple)
aws/resource_aws_kinesis_firehose_delivery_stream.go:2247:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_kinesis_stream.go:69:6:warning: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008) (gosimple)
aws/resource_aws_kms_grant.go:278:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_kms_grant.go:432:2:warning: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008) (gosimple)
aws/resource_aws_kms_grant.go:509:36:warning: should use make(map[string]interface{}) instead (S1019) (gosimple)
aws/resource_aws_kms_grant_test.go:145:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_lambda_function_test.go:382:14:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_launch_configuration.go:628:69:warning: should use make(map[string]map[string]interface{}) instead (S1019) (gosimple)
aws/resource_aws_lb.go:560:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_lb.go:634:38:warning: should use make(map[string]interface{}) instead (S1019) (gosimple)
aws/resource_aws_lb_cookie_stickiness_policy_test.go:97:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_lb_cookie_stickiness_policy_test.go:97:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_lb_target_group_attachment_test.go:106:3:warning: should write targetGroupArn := rs.Primary.Attributes["target_group_arn"] instead of targetGroupArn, _ := rs.Primary.Attributes["target_group_arn"] (S1005) (gosimple)
aws/resource_aws_lb_target_group_attachment_test.go:111:6:warning: should omit comparison to bool constant, can be simplified to hasPort (S1002) (gosimple)
aws/resource_aws_lb_target_group_attachment_test.go:142:3:warning: should write targetGroupArn := rs.Primary.Attributes["target_group_arn"] instead of targetGroupArn, _ := rs.Primary.Attributes["target_group_arn"] (S1005) (gosimple)
aws/resource_aws_lb_target_group_attachment_test.go:147:6:warning: should omit comparison to bool constant, can be simplified to hasPort (S1002) (gosimple)
aws/resource_aws_lightsail_domain.go:75:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_load_balancer_backend_server_policy.go:99:3:warning: should replace loop with policyNames = append(policyNames, backendServer.PolicyNames...) (S1011) (gosimple)
aws/resource_aws_load_balancer_listener_policy.go:99:3:warning: should replace loop with policyNames = append(policyNames, listener.PolicyNames...) (S1011) (gosimple)
aws/resource_aws_load_balancer_listener_policy_test.go:19:12:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_load_balancer_listener_policy_test.go:20:12:warning: the argument is already a string, there's no need to use fmt.Sprintf (S1025) (gosimple)
aws/resource_aws_media_store_container.go:29:10:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_media_store_container.go:119:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_media_store_container_policy_test.go:107:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_media_store_container_policy_test.go:107:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_media_store_container_test.go:91:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_media_store_container_test.go:91:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_mq_broker.go:323:31:warning: should use make([]*mq.User, len(out.Users)) instead (S1019) (gosimple)
aws/resource_aws_mq_broker.go:342:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_mq_broker.go:499:48:warning: should use make(map[string]interface{}) instead (S1019) (gosimple)
aws/resource_aws_neptune_cluster.go:616:5:warning: should omit comparison to bool constant, can be simplified to !skipFinalSnapshot (S1002) (gosimple)
aws/resource_aws_neptune_cluster.go:705:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_neptune_cluster.go:718:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_neptune_cluster_instance.go:307:7:warning: should omit comparison to bool constant, can be simplified to aws.BoolValue(m.IsClusterWriter) (S1002) (gosimple)
aws/resource_aws_neptune_cluster_instance.go:463:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_neptune_subnet_group.go:112:3:warning: should replace loop with subnetGroups = append(subnetGroups, resp.DBSubnetGroups...) (S1011) (gosimple)
aws/resource_aws_neptune_subnet_group.go:131:2:warning: should merge variable declaration with assignment on next line (S1021) (gosimple)
aws/resource_aws_network_acl.go:77:9:warning: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008) (gosimple)
aws/resource_aws_network_acl.go:130:9:warning: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008) (gosimple)
aws/resource_aws_network_acl.go:223:6:warning: should omit comparison to bool constant, can be simplified to *e.Egress (S1002) (gosimple)
aws/resource_aws_network_acl_rule.go:128:5:warning: should omit comparison to bool constant, can be simplified to !hasCidr (S1002) (gosimple)
aws/resource_aws_network_acl_rule.go:128:25:warning: should omit comparison to bool constant, can be simplified to !hasIpv6Cidr (S1002) (gosimple)
aws/resource_aws_network_acl_test.go:574:7:warning: should omit comparison to bool constant, can be simplified to !*e.Egress (S1002) (gosimple)
aws/resource_aws_network_interface_test.go:256:6:warning: should omit comparison to bool constant, can be simplified to !*conf.SourceDestCheck (S1002) (gosimple)
aws/resource_aws_opsworks_application.go:620:2:warning: redundant return statement (S1023) (gosimple)
aws/resource_aws_opsworks_instance.go:588:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_opsworks_instance.go:858:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_opsworks_permission.go:101:5:warning: should omit comparison to bool constant, can be simplified to !found (S1002) (gosimple)
aws/resource_aws_opsworks_rds_db_instance.go:68:5:warning: should omit comparison to bool constant, can be simplified to requestUpdate (S1002) (gosimple)
aws/resource_aws_opsworks_rds_db_instance.go:124:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_opsworks_rds_db_instance.go:160:5:warning: should omit comparison to bool constant, can be simplified to !found (S1002) (gosimple)
aws/resource_aws_pinpoint_app.go:265:5:warning: should omit nil check; len() for nil slices is defined as zero (S1009) (gosimple)
aws/resource_aws_pinpoint_app.go:303:5:warning: should omit nil check; len() for nil slices is defined as zero (S1009) (gosimple)
aws/resource_aws_pinpoint_app.go:346:5:warning: should omit nil check; len() for nil slices is defined as zero (S1009) (gosimple)
aws/resource_aws_placement_group.go:147:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_rds_cluster.go:1138:5:warning: should omit comparison to bool constant, can be simplified to !skipFinalSnapshot (S1002) (gosimple)
aws/resource_aws_rds_cluster.go:1223:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_rds_cluster.go:1236:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_rds_cluster_instance.go:349:7:warning: should omit comparison to bool constant, can be simplified to *m.IsClusterWriter (S1002) (gosimple)
aws/resource_aws_rds_cluster_instance.go:541:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_redshift_cluster.go:896:5:warning: should omit comparison to bool constant, can be simplified to !skipFinalSnapshot (S1002) (gosimple)
aws/resource_aws_redshift_cluster_test.go:176:14:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_redshift_snapshot_copy_grant.go:124:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_redshift_snapshot_copy_grant_test.go:45:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_route.go:400:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_route.go:421:2:warning: should merge variable declaration with assignment on next line (S1021) (gosimple)
aws/resource_aws_route.go:444:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_route53_health_check.go:376:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_route53_record.go:739:2:warning: 'if err != nil { return err }; return err' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_route53_record_test.go:586:18:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_route53_zone.go:132:2:warning: should merge variable declaration with assignment on next line (S1021) (gosimple)
aws/resource_aws_route53_zone_association.go:137:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_s3_bucket_inventory.go:360:36:warning: should use make(map[string]interface{}) instead (S1019) (gosimple)
aws/resource_aws_s3_bucket_notification_test.go:249:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_s3_bucket_notification_test.go:306:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_s3_bucket_notification_test.go:363:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_s3_bucket_object_test.go:418:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_s3_bucket_object_test.go:490:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_s3_bucket_object_test.go:520:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_s3_bucket_test.go:1527:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_s3_bucket_test.go:1574:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_s3_bucket_test.go:1630:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_s3_bucket_test.go:1654:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_s3_bucket_test.go:1681:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_s3_bucket_test.go:1704:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_s3_bucket_test.go:1726:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_s3_bucket_test.go:1741:3:warning: should write tb := s.RootModule().Resources[b] instead of tb, _ := s.RootModule().Resources[b] (S1005) (gosimple)
aws/resource_aws_s3_bucket_test.go:1769:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_secretsmanager_secret.go:351:25:warning: should use make([]*string, len(remove)) instead (S1019) (gosimple)
aws/resource_aws_security_group.go:1140:7:warning: should omit comparison to bool constant, can be simplified to r["self"].(bool) (S1002) (gosimple)
aws/resource_aws_security_group_rules_matching_test.go:662:7:warning: should replace loop with lcs = append(lcs, s["cidr_blocks"].([]interface{})...) (S1011) (gosimple)
aws/resource_aws_service_discovery_private_dns_namespace.go:133:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_service_discovery_public_dns_namespace.go:132:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_service_discovery_public_dns_namespace_test.go:103:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_service_discovery_public_dns_namespace_test.go:103:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_service_discovery_service.go:242:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_service_discovery_service_test.go:139:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_service_discovery_service_test.go:139:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_servicecatalog_portfolio_test.go:144:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_servicecatalog_portfolio_test.go:144:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ses_configuration_set.go:78:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ses_domain_dkim_test.go:73:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_ses_domain_dkim_test.go:84:4:warning: should write token := rs.Primary.Attributes[key] instead of token, _ := rs.Primary.Attributes[key] (S1005) (gosimple)
aws/resource_aws_ses_domain_identity_test.go:121:3:warning: should write rs := s.RootModule().Resources[n] instead of rs, _ := s.RootModule().Resources[n] (S1005) (gosimple)
aws/resource_aws_ses_event_destination.go:203:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ses_receipt_rule.go:578:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ses_receipt_rule_set.go:76:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ses_receipt_rule_set_test.go:86:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ses_receipt_rule_set_test.go:86:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ses_template_test.go:122:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ses_template_test.go:122:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_sfn_activity_test.go:75:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_sfn_activity_test.go:75:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_sfn_activity_test.go:112:3:warning: 'if retryErr != nil { return retryErr }; return nil' can be simplified to 'return retryErr' (S1013) (gosimple)
aws/resource_aws_sfn_state_machine_test.go:68:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_sfn_state_machine_test.go:68:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_sns_platform_application.go:238:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_sns_platform_application_test.go:381:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_sns_platform_application_test.go:381:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_sns_topic.go:239:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_sns_topic.go:265:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_sns_topic_subscription.go:200:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_sns_topic_subscription_test.go:357:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_sns_topic_subscription_test.go:357:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_spot_fleet_request.go:454:27:warning: should omit comparison to bool constant, can be simplified to associatePublicIpAddress.(bool) (S1002) (gosimple)
aws/resource_aws_spot_fleet_request_test.go:723:9:warning: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007) (gosimple)
aws/resource_aws_sqs_queue.go:346:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ssm_document.go:368:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ssm_document_test.go:322:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ssm_document_test.go:322:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ssm_maintenance_window.go:153:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ssm_maintenance_window_target.go:142:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ssm_maintenance_window_target.go:160:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ssm_maintenance_window_task.go:282:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ssm_parameter.go:161:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ssm_parameter_test.go:311:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ssm_parameter_test.go:311:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ssm_patch_baseline.go:276:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_ssm_patch_group.go:90:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_subnet_test.go:119:6:warning: should omit comparison to bool constant, can be simplified to !*v.MapPublicIpOnLaunch (S1002) (gosimple)
aws/resource_aws_subnet_test.go:219:6:warning: should omit comparison to bool constant, can be simplified to !*subnet.AssignIpv6AddressOnCreation (S1002) (gosimple)
aws/resource_aws_subnet_test.go:229:6:warning: should omit comparison to bool constant, can be simplified to *subnet.AssignIpv6AddressOnCreation (S1002) (gosimple)
aws/resource_aws_vpc_dhcp_options_association.go:90:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_vpc_endpoint_service_test.go:81:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_vpc_endpoint_test.go:204:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_vpc_peering_connection.go:216:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_vpc_peering_connection_test.go:74:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_vpc_peering_connection_test.go:138:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_vpn_connection_route.go:131:2:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_vpn_connection_route_test.go:140:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/resource_aws_vpn_connection_route_test.go:140:3:warning: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013) (gosimple)
aws/s3_tags.go:131:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tags.go:293:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tags.go:306:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsBeanstalk.go:67:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsCloudtrail.go:106:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsDAX.go:24:25:warning: should use make([]*string, len(remove)) instead (S1019) (gosimple)
aws/tagsDAX.go:109:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsDS.go:24:25:warning: should use make([]*string, len(remove)) instead (S1019) (gosimple)
aws/tagsDS.go:109:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsDX.go:46:25:warning: should use make([]*string, len(remove)) instead (S1019) (gosimple)
aws/tagsDX.go:131:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsEC.go:24:25:warning: should use make([]*string, len(remove)) instead (S1019) (gosimple)
aws/tagsEC.go:109:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsEFS.go:108:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsELB.go:108:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsGeneric.go:63:40:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsInspector.go:33:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsKMS.go:24:25:warning: should use make([]*string, len(remove)) instead (S1019) (gosimple)
aws/tagsKMS.go:109:48:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsNeptune.go:25:25:warning: should use make([]*string, len(remove)) instead (S1019) (gosimple)
aws/tagsNeptune.go:110:61:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsRDS.go:25:25:warning: should use make([]*string, len(remove)) instead (S1019) (gosimple)
aws/tagsRDS.go:127:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsRedshift.go:22:25:warning: should use make([]*string, len(remove)) instead (S1019) (gosimple)
aws/tagsRedshift.go:102:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsSSM.go:24:25:warning: should use make([]*string, len(remove)) instead (S1019) (gosimple)
aws/tagsSSM.go:111:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tagsSecretsManager.go:68:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tags_elasticsearchservice.go:108:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tags_kinesis.go:139:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
aws/tags_route53.go:105:45:warning: should omit comparison to bool constant, can be simplified to r (S1002) (gosimple)
bflad
vnguyen7
ghost
The fixes for this linter should be done per-resource or per-service since it affects actual logic in almost all cases and will require acceptance testing.
gometalinter --disable-all --enable gosimple ./awsissuesgosimplein TravisCI via.gometalinter.jsonconfiguration