hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.
https://registry.terraform.io/providers/hashicorp/aws
Mozilla Public License 2.0
9.74k stars 9.09k forks source link

New Feature Request: Support for Workmail #6430

Open ghost opened 5 years ago

ghost commented 5 years ago

This issue was originally opened by @ruzin as hashicorp/terraform#19346. It was migrated here as a result of the provider split. The original body of the issue is below.


Current Terraform Version

Terraform v0.11.10
...

Use-cases

Add Workmail Resource to AWS Provider so that one is able to create, update, read and delete a workmail user.

Hey guys,

I think it'd useful to extend the provider to include the workmail service. I'm learning go atm with the view to create a PR to add workmail. However, workmail is quite a broad resource in that it includes creation of the resource itself and sub resources. Is there any useful material/recommended reading? Thanks!

ruzin commented 5 years ago

The main use case behind this is to fully automate the creation of AWS accounts under AWS organizations. I built a half terraform/half boto3 solution (https://github.com/ruzin/muppet) which can be called as a terraform module to do this but it would be better to have it all in terraform.

ruzin commented 5 years ago

@bflad I tried to open a PR to start working on this issue. But I couldn't push up my local branch. This is my first time contributing to an open source project. So any help appreciated? Thanks

bflad commented 5 years ago

Hi @ruzin ๐Ÿ‘‹ Very exciting!

If you are unfamiliar with social coding on GitHub, I would recommend checking out GitHub Guides. In particular to your problem, the one on Forking might be useful. There's also GitHub Help pages as well: https://help.github.com/articles/fork-a-repo/

Essentially you'll create a "personal copy" of the codebase on GitHub, push up the change to your fork, then submit the change as a pull request back to the main codebase. Hope this gets you started.

ruzin commented 5 years ago

@bflad Ah I see! I was wondering why there were so few branches but so many PRs. makes sense. Thank you, ill try that.

Jeeppler commented 5 years ago

@ruzin are you still working on this feature?

cicdguy commented 5 years ago

Hi guys, let me know if you need any help with this. I can help contribute. Looking forward to this feature!

OGProgrammer commented 5 years ago

Same here!

andy-hammond commented 5 years ago

+1! Would love to be able tie off the account creation process

ruzin commented 4 years ago

hey guys! I haven't been working on this, sorry got sidetracked. please feel free to pick this up!

sklemmer commented 4 years ago

Is anyone working on this? I would love to automate our company email and calendars with terraform.

lorengordon commented 4 years ago

I see a pr was merged, but for some reason I'm not seeing docs....?

nathantfrank commented 4 years ago

Can someone possibly give an update to the lack of documentation?

kurtmc commented 4 years ago

I would be happy to implement this. I think the first thing that needs to be done is figure out which resources need to be created.

Looking at the SDK documentation (https://docs.aws.amazon.com/sdk-for-go/api/service/workmail/) I think that we would probably want to create the following resources:

And the parameters for each of those would probably closely match the input arguments:

If someone from hashicorp or a maintainer for this provider could tell me if I am going in the right direction for this I would be keen to implement something and create a PR.

kurtmc commented 4 years ago

Something that's blocking this from progressing is that there is no API/SDK support for creating WorkMail organizations. If anyone has some influence at AWS I would appreciate to see it added to the API and SDK.

Edit:

If you want to help bump this up the AWS priority can you please go to https://console.aws.amazon.com/workmail/v2/home?region=us-east-1#/ and hit the feedback button in the bottom left corner and submit a feature request asking for API support for creating AWS WorkMail organizations.

siteopsio commented 3 years ago

@kurtmc There is an API for work mail now and supports organizations. https://awscli.amazonaws.com/v2/documentation/api/latest/reference/workmail/index.html https://docs.aws.amazon.com/workmail/latest/APIReference/workmail-api.pdf

Hope that helps

sachin-101 commented 3 years ago

@kurtmc Any updates?

kurtmc commented 3 years ago

@sachin-101 API support is looking good now, and I see it's in the SDK: https://docs.aws.amazon.com/sdk-for-go/api/service/workmail/#WorkMail.CreateOrganization

I try implement some of it this weekend.

sachin-101 commented 3 years ago

@kurtmc Yeah I did find it in boto3 (Python SDK) docs as well. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/workmail.html#WorkMail.Client.create_organization

But it's only in the docs, and while using the SDK, it says AttributeError: 'WorkMail' object has no attribute 'create_organization'.

Ikana commented 3 years ago

@kurtmc let me know if you need any help with this, I can at least test it ๐Ÿ˜„

robmoss2k commented 2 years ago

The SDK supports a significant number of new methods since @ruzin opened the original ticket. Yesterday saw AWS add API support for mail domains:

https://awsapichanges.info/archive/changes/818967-workmail.html

The SDK already supports these, and many other, methods:

https://docs.aws.amazon.com/sdk-for-go/api/service/workmail/

Is there a guide for how to implement these things?

nikskiz commented 2 years ago

For anyone who came here initially because they had to verify AWS SES sender email. Email verifications is now via DKIM record

Domain verification in Amazon SES is now based on DomainKeys Identified Mail (DKIM), an email authentication standard that receiving mail servers use to validate an emailโ€™s authenticity. Configuring DKIM in your domainโ€™s DNS settings confirms to SES that youโ€™re the identity owner, eliminating the need for TXT records. Domain identities that were verified using TXT records do not need to be reverified; however, we still recommend enabling DKIM signatures to enhance the deliverability of your mail with DKIM-compliant email providers. To access your legacy TXT records, download the record set as a .csv .
sidcarter commented 2 years ago

@kurtmc happy to take a look and help as well

khadersyed commented 2 years ago

I started with a PR above. I would love some help on the testing side of things and any other feedback/review/edits that I need to do. I'd love to work on this and have this merged once it's in a good shape.

lucasff commented 1 year ago

Not so much interest from the community for this one, huh?

DanielViglione commented 1 year ago

I have been following this ticket over time and noticed it has been 4 years now and I still don't see any terraform support for creating Workmail organizations. As others stated, this would be highly useful to automate the full creation of accounts under AWS Organizations. The AWS CLI supports WorkMail Organization creation: https://docs.aws.amazon.com/cli/latest/reference/workmail/create-organization.html

sahaqaa commented 1 year ago

It would be handy if Terraform provider had support of AWS WorkMail.

kschoenberger commented 1 year ago

push.

aleonsan commented 1 year ago

+1 . It would be nice to have support to AWS Workmail

Losty17 commented 1 year ago

+1, hoping this issue go further

g-getsov commented 11 months ago

+1 :pray:

michalkubik01 commented 7 months ago

+1 bump

connorgurney-user commented 7 months ago

Seconded (well, twentiethed, or something close to that?!).

YuryHrytsuk commented 5 months ago

+1

IuriAmauri commented 4 months ago

+1

malchesine commented 2 months ago

+1 https://docs.aws.amazon.com/cli/latest/reference/workmail/#cli-aws-workmail Please ๐Ÿ™ ๐Ÿ™ ๐Ÿ™ ๐Ÿ™

arevik-zealous commented 1 month ago

+1 It would be great if the Terraform provider had support for AWS WorkMail.