Extend LB Listener Rule Condition Support

hashicorp / terraform-provider-aws

The AWS Provider enables Terraform to manage AWS resources.

https://registry.terraform.io/providers/hashicorp/aws

Mozilla Public License 2.0

9.83k stars 9.18k forks source link

Extend LB Listener Rule Condition Support #9360

Closed stack72 closed 5 years ago

stack72 commented 5 years ago

The lb_listener_rule condition needs to have extensions that allow not just host-header and path-pattern conditions.

It needs to be able to support:

http-header
http-request-method
query-string
source-ip

Each of these new condition types have their struct in the AWS SDK, therefore the schema will need to adapt to allow them - this will more than likely mean a state migration due to condition being schema.TypeSet

ewbankkit commented 5 years ago

I THINK (not 100% positive, please check PR) that this is being addressed in https://github.com/terraform-providers/terraform-provider-aws/issues/8126, https://github.com/terraform-providers/terraform-provider-aws/pull/8268.

stack72 commented 5 years ago

Duplicate of #8126

stack72 commented 5 years ago

Thanks for that @ewbankkit :)

ghost commented 5 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!