hashicorp / terraform-provider-awscc

Terraform AWS Cloud Control provider
https://registry.terraform.io/providers/hashicorp/awscc/latest/docs
Mozilla Public License 2.0
248 stars 113 forks source link

Upgrading awscc provider to anything more than 1.0.0 creates a new change in awscc_chatbot_slack_channel_configuration and times out on apply #1882

Closed trixobird closed 1 month ago

trixobird commented 1 month ago

Community Note

Terraform CLI and Terraform AWS Cloud Control Provider Version

Terraform v1.9.2
on darwin_arm64
+ provider registry.terraform.io/hashicorp/aws v5.58.0
+ provider registry.terraform.io/hashicorp/awscc v1.5.0
+ provider registry.terraform.io/hashicorp/external v2.3.3
+ provider registry.terraform.io/hashicorp/random v3.6.2
+ provider registry.terraform.io/hashicorp/tfe v0.57.0
+ provider registry.terraform.io/vercel/vercel v1.12.0

Affected Resource(s)

awscc_chatbot_slack_channel_configuration

Terraform Configuration Files

The whole repo is open sourced. This is the file in question

resource "awscc_chatbot_slack_channel_configuration" "error_slack_channel_configuration" {
  configuration_name = "${var.environment}-slack-channel-config"
  iam_role_arn       = awscc_iam_role.slack_assume_role.arn
  logging_level      = "ERROR"
  slack_channel_id   = "errors"
  slack_workspace_id = var.slack_workspace_id
  sns_topic_arns     = [module.server.sns_app_runner_error_topic_arn, aws_sns_topic.channel_ingress_error_topic.arn]
}

Debug Output

https://app.terraform.io/app/adsviewer/workspaces/prod/runs/run-qEuDcbfRK2bNQ5Ge

Expected Behavior

There should be no changes in the configuration

Actual Behavior

There was a change in module.environment.awscc_chatbot_slack_channel_configuration.error_slack_channel_configuration due to

no-op
id :
"arn:aws:chatbot::***:chat-configuration/slack-channel/prod-slack-channel-config"

What happened

I upgraded hashicorp/awscc version from 1.0.0 to 1.5.0 and I noticed that instead of no changes had this change in awscc_chatbot_slack_channel_configuration. When I tried to apply the process timed out after 2h. I am using terraform cloud so you should have access to the whole run.

I tried upgrading to 1.2.0, 1.3, 1.4 the same result, the plan had a new change. In 1.1.0 there was an error during the plan, you may find it here: https://app.terraform.io/app/adsviewer/workspaces/prod/runs/run-yzbys9PEebTRTfeo

quixoticmonk commented 1 month ago

Thank you for opening the issue @trixobird. Is your issue similar to https://github.com/hashicorp/terraform-provider-awscc/issues/1841 ? Unfortunately, I cannot see your HCP Terraform workspace runs.

Is the slack channel id in your configuration correct ? slack_channel_id = "errors" . This should be the channel_id which is usually a 9 char string.

trixobird commented 1 month ago

Thank you for opening the issue @trixobird. Is your issue similar to #1841 ? Unfortunately, I cannot see your HCP Terraform workspace runs.

Is the slack channel id in your configuration correct ? slack_channel_id = "errors" . This should be the channel_id which is usually a 9 char string.

yes this is exactly the same, apologies for opening a new one. I did see it, but for some reason my mind didn't register it :'(